Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language selection does not work anymore #354

Closed
MalteHillmann opened this Issue Feb 28, 2019 · 7 comments

Comments

Projects
None yet
2 participants
@MalteHillmann
Copy link

MalteHillmann commented Feb 28, 2019

It is impossible to change to german language. Neither "System default" nor "Deutsch/German" explicit selection works. My OS is running on german language.

Screenshots
maxto-lang

System information:

  • Windows version: Windows 10 Pro 18.09 (17763.316)
  • MaxTo version: 2.0.0-rc1

Additional context
%AppData%\MaxTo\maxto.log contains no data corresponding to this issue.

@MalteHillmann MalteHillmann changed the title Language selectioon does not work anymore Language selection does not work anymore Feb 28, 2019

@vegardlarsen

This comment has been minimized.

Copy link
Member

vegardlarsen commented Mar 4, 2019

Does it work if you edit it in %AppData%\MaxTo\config.json? The correct ISO code to put for German is de.

@MalteHillmann

This comment has been minimized.

Copy link
Author

MalteHillmann commented Mar 4, 2019

It is already set to "de":

{
  "$schema": "https://maxto.net/config.schema.json",
  "language": "de",
[...]
}
@vegardlarsen

This comment has been minimized.

Copy link
Member

vegardlarsen commented Mar 4, 2019

Do you have a subfolder in the MaxTo installation directory (%LocalAppData%\MaxTo\app-2.0.0-rc1) called de with 3 DLLs in it?

@vegardlarsen vegardlarsen added the bug label Mar 4, 2019

@vegardlarsen vegardlarsen self-assigned this Mar 4, 2019

@vegardlarsen vegardlarsen added this to the 2.0.0 milestone Mar 4, 2019

@vegardlarsen

This comment has been minimized.

Copy link
Member

vegardlarsen commented Mar 4, 2019

This apparently happens in every language except English and Norwegian. I am investigating this issue.

@MalteHillmann

This comment has been minimized.

Copy link
Author

MalteHillmann commented Mar 4, 2019

Do you have a subfolder in the MaxTo installation directory (%LocalAppData%\MaxTo\app-2.0.0-rc1) called de with 3 DLLs in it?

Yes:

MaxTo.Core.resources.dll
MaxTo.resources.dll
Microsoft.Win32.TaskScheduler.resources.dll

@vegardlarsen vegardlarsen modified the milestones: 2.0.0, 2.0.0-rc.2 Mar 5, 2019

@vegardlarsen

This comment has been minimized.

Copy link
Member

vegardlarsen commented Mar 5, 2019

I have made headway into figuring out what happened here. It was a issue on the build server, where our tooling did not insert the correct embedded resources (i.e. the translated strings) into the UI project's .csproj file. I am rectifying this by adding better tooling.

It worked for Norwegian and English because those languages were not being imported live from POEditor, but were already included in our source repository.

The fix for this will be in 2.0.0-rc.2.

@vegardlarsen

This comment has been minimized.

Copy link
Member

vegardlarsen commented Mar 6, 2019

This has now been fixed, and will be in 2.0.0-rc.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.