Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using self-made presets with regions:cycle crashes #695

Closed
vegardlarsen opened this issue Jan 22, 2021 · 1 comment
Closed

Using self-made presets with regions:cycle crashes #695

vegardlarsen opened this issue Jan 22, 2021 · 1 comment
Labels
bug Confirmed bug in MaxTo.
Milestone

Comments

@vegardlarsen
Copy link
Member

Describe the bug
MaxTo crashes when executing the below recipe

{
  "name": "Cycle Presets",
  "hotkey": null,
  "triggers": [
    {
      "type": "keyboard:hotkey",
      "Hotkey": "Control+Windows+Z"
    }
  ],
  "ingredients": [
    {
      "command": "regions:cycle",
      "parameters": {
        "monitor": "$current",
        "presets": "Two-way vertical,Ultra-wide three-way,Four Screens"
      }
    }
  ]
}

To Reproduce

  1. Import the recipe above (ensure you have the "Four Screens" preset).
  2. Run it.
  3. NullReferenceException.

Expected behavior
No crash.

System information:

  • Windows version: 10 20H2 (19042.746)
  • MaxTo version: 2.1.5

Additional context

Stack trace from log:

This produces the following stack trace:

[MaxTo.Core.Keyboard.RecipeExecutor] Executing recipe '"Cycle Presets"' with 1 ingredients
2021-01-22 19:42:41 [Core@2.1.5.732] [Warning] [MaxTo.Core.Keyboard.RecipeExecutor] Received exception from command request 1 while executing '"Cycle Presets"'. Aborting.
System.NullReferenceException: Object reference not set to an instance of an object.
   at MaxTo.Core.Commands.Regions.CycleCommand.<Execute>d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at MaxTo.Core.Commands.CommandBase`2.<Execute>d__1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at MaxTo.Core.Commands.CommandExecutor.<Execute>d__2.MoveNext()
@vegardlarsen vegardlarsen added the bug Confirmed bug in MaxTo. label Jan 22, 2021
@vegardlarsen vegardlarsen added this to the 2.2.0 milestone Jan 22, 2021
@vegardlarsen
Copy link
Member Author

The cause has been located, fixed, and will be released in version 2.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bug in MaxTo.
Projects
None yet
Development

No branches or pull requests

1 participant