Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape region names #697

Closed
xairoo opened this issue Jan 29, 2021 · 3 comments
Closed

Escape region names #697

xairoo opened this issue Jan 29, 2021 · 3 comments
Labels
bug Confirmed bug in MaxTo.
Milestone

Comments

@xairoo
Copy link

xairoo commented Jan 29, 2021

You should escape region names.

I have 3 regions (just shorted for this example)

  • Full
  • 1/1
  • 1460, 2380

The last name will run you into problem. Just escape the names

{
    "command": "regions:cycle",
    "parameters": {
        "presets": "Full,1/1,1460, 2380",
        "monitor": "97F8P91C06UL"
    }
}

Should be something like:
"presets": "'Full', '1/1', '1460, 2380'",

@vegardlarsen vegardlarsen added the bug Confirmed bug in MaxTo. label Feb 3, 2021
@vegardlarsen
Copy link
Member

This should really have been an array in the JSON, not a string. This will be fixed. :)

@vegardlarsen vegardlarsen added this to the 2.2.0 milestone Feb 3, 2021
@vegardlarsen
Copy link
Member

I have fixed this for the next 2.2.0-release (maybe another beta, maybe final).

Just while writing this comment, I discovered that this change breaks previously correct configurations (e.g. normal preset names without commas in them will be broken), so I am reopening and will fix this as well.

@vegardlarsen vegardlarsen reopened this Apr 16, 2021
@vegardlarsen
Copy link
Member

Now it is solved. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bug in MaxTo.
Projects
None yet
Development

No branches or pull requests

2 participants