Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to LinkedIn Profile removed Credential URL and retains Credential ID #201

Closed
bmuramatsu opened this issue Aug 25, 2022 · 8 comments
Closed

Add to LinkedIn Profile removed Credential URL and retains Credential ID #201

bmuramatsu opened this issue Aug 25, 2022 · 8 comments
Assignees
@dmitrizagidulin

Comments

@bmuramatsu
Copy link
Collaborator

This may have been wrong in the PR, but it's definitely wrong in the build.

Add to LinkedIn Profile should have the VerifierPlus public share URL and no Credential ID.
@dmitrizagidulin dmitrizagidulin added the re-test Needs re-testing to see if been fixed. label Mar 16, 2023
@kayaelle kayaelle added the bug Schedule this bug label Apr 20, 2023
@kayaelle kayaelle assigned kayaelle and dmitrizagidulin and unassigned kayaelle Jul 11, 2023
@kayaelle
Copy link
Member

Dmitri will test after publishing LinkedIn date fix.

@kayaelle
Copy link
Member

@dmitrizagidulin - please check to see if this was included in recent build.

@dmitrizagidulin
Copy link
Member

Ah ok, I think I may have misunderstood the issue originally. The Credential ID /is/ still being included. I'll remove it and republish.

@kayaelle kayaelle added this to the v2.0.11-build66 milestone Aug 16, 2023
@kayaelle kayaelle removed the bug Schedule this bug label Aug 16, 2023
@kayaelle
Copy link
Member

@dmitrizagidulin - can this be closed?

@kayaelle kayaelle added the question Further information is requested label Aug 17, 2023
@kayaelle kayaelle removed this from the v2.0.11-build66 milestone Aug 17, 2023
@dmitrizagidulin dmitrizagidulin mentioned this issue Aug 17, 2023
Merged
@dmitrizagidulin
Copy link
Member

Addressed in PR #487, closing.

@kayaelle kayaelle removed question Further information is requested re-test Needs re-testing to see if been fixed. labels Aug 17, 2023
@kayaelle
Copy link
Member

Looks good @dmitrizagidulin

@bmuramatsu
Copy link
Collaborator Author

@dmitrizagidulin For LCW v2.0.11-Build 66, both iOS and Android, I'm still seeing our urn:uuid... in the Credential ID field when Adding to LinkedIn.

@bmuramatsu bmuramatsu reopened this Aug 22, 2023
@kayaelle
Copy link
Member

kayaelle commented Sep 6, 2023

I've confirmed that credential id is empty when sharing a credential to LinkedIn in both iOS and Android.

@kayaelle kayaelle closed this as completed Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitrizagidulin dmitrizagidulin

Labels
None yet
Projects
DCC Engineering
Status: Done (Deployed)
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kayaelle @bmuramatsu @dmitrizagidulin