Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fish completions #767

Merged
merged 4 commits into from Mar 20, 2020
Merged

Conversation

@KeisukeYamashita
Copy link
Contributor

KeisukeYamashita commented Mar 20, 2020

What

As title, I implemented a fish shell completions.

Why

For better developer experience. There was bash & zsh shell completion but the fish shell was missing.

Solves part of #238.

Copy link
Contributor

Verolop left a comment

Lgtm.
Thanks!

@Verolop Verolop merged commit 4ab41bb into digitalocean:master Mar 20, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
guardrails/scan no new security issues detected (in 00m25s)
Details
@MattIPv4

This comment has been minimized.

Copy link
Member

MattIPv4 commented Mar 20, 2020

Hey, @KeisukeYamashita - Thanks a ton for this sweet PR! 😄

Would you please shoot me an email when you get a chance?
mcowley at digitalocean dot com 🎉

@KeisukeYamashita

This comment has been minimized.

Copy link
Contributor Author

KeisukeYamashita commented Mar 21, 2020

@MattIPv4 Thanks, I sent you an email, please take a look😊

@KeisukeYamashita KeisukeYamashita deleted the KeisukeYamashita:add-fish-completion branch Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.