registry: Remove dependency on Docker binary for login/logout #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
andrewsomething
force-pushed
the
docker-login
branch
from
b0c0f16
to
1c5bda3
Compare
This comment has been minimized.
This comment has been minimized.
andrewsomething
force-pushed
the
docker-login
branch
from
1c5bda3
to
3af8147
Compare
This comment has been minimized.
This comment has been minimized.
andrewsomething
force-pushed
the
docker-login
branch
from
3af8147
to
1a57c4d
Compare
This comment has been minimized.
This comment has been minimized.
Update vendored version of github.com/opencontainers/runc Update vendored packages. Update vendored packages. Update vendored packages.
andrewsomething
force-pushed
the
docker-login
branch
from
1a57c4d
to
a16aa67
Compare
bentranter
reviewed
May 19, 2020
Comment on lines
+255
to
+256
| dockerCreds := cf.GetCredentialsStore(authconfig.ServerAddress) | ||
| err = dockerCreds.Store(authconfig) |
There was a problem hiding this comment.
I think these two operations call cgo. I'm going to pull down your branch right now to check, but if so, it might make our release process more complicated since we may not be able to use Go's built-in cross compilation as part of goreleaser.
There was a problem hiding this comment.
Okay – they do call cgo, but it seems like it does not affect our ability to use Go's usual cross compilation tools, so I think this is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removed the runtime dependency on the Docker binary for the registry login/logout commands. It also adds integration tests for them.
This does not resolve #709 on its own, but it should provide a path forward for getting the correct permissions approved by Canonical.