From 2292f423729b16ed1db47a25513b909d27b4bd7a Mon Sep 17 00:00:00 2001 From: olehp Date: Fri, 19 Jan 2024 12:02:04 +0200 Subject: [PATCH 1/8] Added code nexus point insight --- .../CodeNexusInsight.stories.tsx | 23 +++++++ .../Insights/CodeNexusInsight/index.tsx | 43 +++++++++++++ .../Insights/CodeNexusInsight/mockData.ts | 62 +++++++++++++++++++ .../Insights/CodeNexusInsight/styles.ts | 29 +++++++++ .../Insights/CodeNexusInsight/types.ts | 9 +++ src/components/Insights/typeGuards.ts | 6 ++ src/components/Insights/types.ts | 9 +++ src/types.ts | 3 +- src/utils/getInsightTypeInfo.ts | 4 ++ 9 files changed, 187 insertions(+), 1 deletion(-) create mode 100644 src/components/Insights/CodeNexusInsight/CodeNexusInsight.stories.tsx create mode 100644 src/components/Insights/CodeNexusInsight/index.tsx create mode 100644 src/components/Insights/CodeNexusInsight/mockData.ts create mode 100644 src/components/Insights/CodeNexusInsight/styles.ts create mode 100644 src/components/Insights/CodeNexusInsight/types.ts diff --git a/src/components/Insights/CodeNexusInsight/CodeNexusInsight.stories.tsx b/src/components/Insights/CodeNexusInsight/CodeNexusInsight.stories.tsx new file mode 100644 index 000000000..0f9be478e --- /dev/null +++ b/src/components/Insights/CodeNexusInsight/CodeNexusInsight.stories.tsx @@ -0,0 +1,23 @@ +import { Meta, StoryObj } from "@storybook/react"; +import { CodeNexusInsight } from "."; +import { mockedCodeNexusInsight } from "./mockData"; + +// More on how to set up stories at: https://storybook.js.org/docs/react/writing-stories/introduction +const meta: Meta = { + title: "Insights/CodeNexusInsight", + component: CodeNexusInsight, + parameters: { + // More on how to position stories at: https://storybook.js.org/docs/react/configure/story-layout + layout: "fullscreen" + } +}; + +export default meta; + +type Story = StoryObj; + +export const Default: Story = { + args: { + insight: mockedCodeNexusInsight + } +}; diff --git a/src/components/Insights/CodeNexusInsight/index.tsx b/src/components/Insights/CodeNexusInsight/index.tsx new file mode 100644 index 000000000..56982667d --- /dev/null +++ b/src/components/Insights/CodeNexusInsight/index.tsx @@ -0,0 +1,43 @@ +import { Tag } from "../../common/Tag"; +import { InsightCard } from "../InsightCard"; +import { Description } from "../styles"; +import * as s from "./styles"; +import { CodeNexusInsightProps, } from "./types"; + +export const CodeNexusInsight = ( + props: CodeNexusInsightProps +) => { + const { insight } = props; + return ( + + + Multiple code flows depned on this location + + + + Services + + + + Edpoints + + + + Flows + + + + Usage + + + + + } + onRecalculate={props.onRecalculate} + onRefresh={props.onRefresh} + /> + ); +}; diff --git a/src/components/Insights/CodeNexusInsight/mockData.ts b/src/components/Insights/CodeNexusInsight/mockData.ts new file mode 100644 index 000000000..eb6500f0c --- /dev/null +++ b/src/components/Insights/CodeNexusInsight/mockData.ts @@ -0,0 +1,62 @@ +import { InsightType } from "../../../types"; +import { + CodeNexusInsight, + InsightCategory, + InsightScope +} from "../types"; + +export const mockedCodeNexusInsight: CodeNexusInsight = + { + firstDetected: "2023-12-05T17:25:47.010Z", + lastDetected: "2024-01-05T13:14:47.010Z", + criticality: 0, + impact: 0, + firstCommitId: "b3f7b3f", + lastCommitId: "a1b2c3d", + deactivatedCommitId: null, + reopenCount: 0, + ticketLink: null, + name: "Code Nexus Point", + type: InsightType.CodeNexus, + category: InsightCategory.Usage, + specifity: 2, + importance: 3, + scope: InsightScope.Span, + spanInfo: { + name: "HTTP POST /owners/{ownerId}/pets/new", + displayName: "HTTP POST /owners/{ownerId}/pets/new", + instrumentationLibrary: "io.opentelemetry.tomcat-10.0", + spanCodeObjectId: + "span:io.opentelemetry.tomcat-10.0$_$HTTP POST /owners/{ownerId}/pets/new", + methodCodeObjectId: + "method:org.springframework.samples.petclinic.owner.PetController$_$processCreationForm", + kind: "Server", + codeObjectId: + "org.springframework.samples.petclinic.owner.PetController$_$processCreationForm" + }, + shortDisplayInfo: { + title: "", + targetDisplayName: "", + subtitle: "", + description: "" + }, + codeObjectId: + "org.springframework.samples.petclinic.owner.PetController$_$processCreationForm", + decorators: [ + { + title: "Excessive HTTP Calls", + description: "Numerous Http calls to the same endpoint detected " + } + ], + environment: "BOB-LAPTOP[LOCAL]", + severity: 0.0, + isRecalculateEnabled: false, + prefixedCodeObjectId: + "method:org.springframework.samples.petclinic.owner.PetController$_$processCreationForm", + customStartTime: null, + actualStartTime: "2023-08-10T08:04:00Z", + flowsCount :4, + servicesCount: 3, + usage: 'High', + endpointsCount: 5, + }; diff --git a/src/components/Insights/CodeNexusInsight/styles.ts b/src/components/Insights/CodeNexusInsight/styles.ts new file mode 100644 index 000000000..5f6c54d93 --- /dev/null +++ b/src/components/Insights/CodeNexusInsight/styles.ts @@ -0,0 +1,29 @@ +import styled from "styled-components"; + +export const ContentContainer = styled.div` + display: flex; + flex-direction: column; + gap: 8px; +`; + +export const Stats = styled.div` + display: flex; + border-radius: 4px; + gap: 20px; + justify-content: space-between; +`; + +export const Stat = styled.div` + display: flex; + flex-direction: column; + gap: 8px; + overflow: hidden; +`; + +export const Key = styled.span` + font-size: 14px; + font-weight: 510; + white-space: nowrap; + text-overflow: ellipsis; + overflow: hidden; +`; diff --git a/src/components/Insights/CodeNexusInsight/types.ts b/src/components/Insights/CodeNexusInsight/types.ts new file mode 100644 index 000000000..175c39e3a --- /dev/null +++ b/src/components/Insights/CodeNexusInsight/types.ts @@ -0,0 +1,9 @@ + +import { + CodeNexusInsight, + InsightProps, +} from "../types"; + +export interface CodeNexusInsightProps extends InsightProps { + insight: CodeNexusInsight; +} diff --git a/src/components/Insights/typeGuards.ts b/src/components/Insights/typeGuards.ts index a18a2ce5f..9dd7aad60 100644 --- a/src/components/Insights/typeGuards.ts +++ b/src/components/Insights/typeGuards.ts @@ -1,6 +1,7 @@ import { InsightType } from "../../types"; import { ChattyApiEndpointInsight, + CodeNexusInsight, CodeObjectErrorsInsight, CodeObjectHotSpotInsight, CodeObjectInsight, @@ -133,3 +134,8 @@ export const isEndpointHighNumberOfQueriesInsight = ( insight: CodeObjectInsight ): insight is EndpointHighNumberOfQueriesInsight => insight.type === InsightType.EndpointHighNumberOfQueries; + +export const isCodeNexusInsight = ( + insight: CodeObjectInsight +): insight is CodeNexusInsight => + insight.type === InsightType.CodeNexus; diff --git a/src/components/Insights/types.ts b/src/components/Insights/types.ts index 6d78f2a5e..1cf83ae9c 100644 --- a/src/components/Insights/types.ts +++ b/src/components/Insights/types.ts @@ -682,3 +682,12 @@ export interface EndpointHighNumberOfQueriesInsight extends EndpointInsight { requestFraction: number; quantile?: number; } + +export interface CodeNexusInsight extends SpanInsight { + type: InsightType.CodeNexus; + servicesCount: number; + endpointsCount: number; + flowsCount: number; + usage: string | null; +} + diff --git a/src/types.ts b/src/types.ts index 5807c044e..b9d5a2a8b 100644 --- a/src/types.ts +++ b/src/types.ts @@ -31,7 +31,8 @@ export enum InsightType { SpanScalingInsufficientData = "SpanScalingInsufficientData", EndpointSessionInView = "EndpointSessionInView", EndpointChattyApi = "EndpointChattyApi", - EndpointHighNumberOfQueries = "EndpointHighNumberOfQueries" + EndpointHighNumberOfQueries = "EndpointHighNumberOfQueries", + CodeNexus = "CodeNexus", } export type PercentileKey = "p50" | "p95"; diff --git a/src/utils/getInsightTypeInfo.ts b/src/utils/getInsightTypeInfo.ts index eba165ac2..b4ded0bd9 100644 --- a/src/utils/getInsightTypeInfo.ts +++ b/src/utils/getInsightTypeInfo.ts @@ -113,6 +113,10 @@ export const getInsightTypeInfo = ( [InsightType.EndpointHighNumberOfQueries]: { icon: SQLDatabaseIcon, label: "High number of queries" + }, + [InsightType.CodeNexus]: { + icon: BottleneckIcon, // todo changes + label: "Code Nexus Point" } }; From 5cb3fc9b40f9a4cfad2ca2f38c918fc099c710be Mon Sep 17 00:00:00 2001 From: olehp Date: Fri, 19 Jan 2024 14:12:59 +0200 Subject: [PATCH 2/8] rename --- src/components/Insights/CodeNexusInsight/types.ts | 9 --------- src/components/Insights/InsightList/index.tsx | 13 +++++++++++++ .../SpanNexusInsight.stories.tsx} | 12 ++++++------ .../index.tsx | 6 +++--- .../mockData.ts | 8 ++++---- .../styles.ts | 0 src/components/Insights/SpanNexusInsight/types.ts | 9 +++++++++ src/components/Insights/typeGuards.ts | 8 ++++---- src/components/Insights/types.ts | 4 ++-- src/utils/getInsightTypeInfo.ts | 2 +- 10 files changed, 42 insertions(+), 29 deletions(-) delete mode 100644 src/components/Insights/CodeNexusInsight/types.ts rename src/components/Insights/{CodeNexusInsight/CodeNexusInsight.stories.tsx => SpanNexusInsight/SpanNexusInsight.stories.tsx} (63%) rename src/components/Insights/{CodeNexusInsight => SpanNexusInsight}/index.tsx (91%) rename src/components/Insights/{CodeNexusInsight => SpanNexusInsight}/mockData.ts (93%) rename src/components/Insights/{CodeNexusInsight => SpanNexusInsight}/styles.ts (100%) create mode 100644 src/components/Insights/SpanNexusInsight/types.ts diff --git a/src/components/Insights/CodeNexusInsight/types.ts b/src/components/Insights/CodeNexusInsight/types.ts deleted file mode 100644 index 175c39e3a..000000000 --- a/src/components/Insights/CodeNexusInsight/types.ts +++ /dev/null @@ -1,9 +0,0 @@ - -import { - CodeNexusInsight, - InsightProps, -} from "../types"; - -export interface CodeNexusInsightProps extends InsightProps { - insight: CodeNexusInsight; -} diff --git a/src/components/Insights/InsightList/index.tsx b/src/components/Insights/InsightList/index.tsx index 65b346ef7..82a791264 100644 --- a/src/components/Insights/InsightList/index.tsx +++ b/src/components/Insights/InsightList/index.tsx @@ -26,6 +26,7 @@ import { ScalingIssueInsight } from "../ScalingIssueInsight"; import { SessionInViewInsight } from "../SessionInViewInsight"; import { SlowEndpointInsight } from "../SlowEndpointInsight"; import { SpanBottleneckInsight } from "../SpanBottleneckInsight"; +import { SpanNexusInsight } from "../SpanNexusInsight"; import { TopUsageInsight } from "../TopUsageInsight"; import { TrafficInsight } from "../TrafficInsight"; import { actions } from "../actions"; @@ -50,6 +51,7 @@ import { isSpanEndpointBottleneckInsight, isSpanInsight, isSpanNPlusOneInsight, + isSpanNexusInsight, isSpanScalingBadlyInsight, isSpanScalingInsufficientDataInsight, isSpanScalingWellInsight, @@ -561,6 +563,17 @@ const renderInsightCard = ( /> ); } + + if (isSpanNexusInsight(insight)) { + return ( + + ); + } }; export const InsightList = (props: InsightListProps) => { diff --git a/src/components/Insights/CodeNexusInsight/CodeNexusInsight.stories.tsx b/src/components/Insights/SpanNexusInsight/SpanNexusInsight.stories.tsx similarity index 63% rename from src/components/Insights/CodeNexusInsight/CodeNexusInsight.stories.tsx rename to src/components/Insights/SpanNexusInsight/SpanNexusInsight.stories.tsx index 0f9be478e..82cc28a9d 100644 --- a/src/components/Insights/CodeNexusInsight/CodeNexusInsight.stories.tsx +++ b/src/components/Insights/SpanNexusInsight/SpanNexusInsight.stories.tsx @@ -1,11 +1,11 @@ import { Meta, StoryObj } from "@storybook/react"; -import { CodeNexusInsight } from "."; -import { mockedCodeNexusInsight } from "./mockData"; +import { SpanNexusInsight } from "."; +import { mockedSpanNexusInsight } from "./mockData"; // More on how to set up stories at: https://storybook.js.org/docs/react/writing-stories/introduction -const meta: Meta = { - title: "Insights/CodeNexusInsight", - component: CodeNexusInsight, +const meta: Meta = { + title: "Insights/SpanNexusInsight", + component: SpanNexusInsight, parameters: { // More on how to position stories at: https://storybook.js.org/docs/react/configure/story-layout layout: "fullscreen" @@ -18,6 +18,6 @@ type Story = StoryObj; export const Default: Story = { args: { - insight: mockedCodeNexusInsight + insight: mockedSpanNexusInsight } }; diff --git a/src/components/Insights/CodeNexusInsight/index.tsx b/src/components/Insights/SpanNexusInsight/index.tsx similarity index 91% rename from src/components/Insights/CodeNexusInsight/index.tsx rename to src/components/Insights/SpanNexusInsight/index.tsx index 56982667d..d5fc6b800 100644 --- a/src/components/Insights/CodeNexusInsight/index.tsx +++ b/src/components/Insights/SpanNexusInsight/index.tsx @@ -2,10 +2,10 @@ import { Tag } from "../../common/Tag"; import { InsightCard } from "../InsightCard"; import { Description } from "../styles"; import * as s from "./styles"; -import { CodeNexusInsightProps, } from "./types"; +import { SpanNexusInsightProps, } from "./types"; -export const CodeNexusInsight = ( - props: CodeNexusInsightProps +export const SpanNexusInsight = ( + props: SpanNexusInsightProps ) => { const { insight } = props; return ( diff --git a/src/components/Insights/CodeNexusInsight/mockData.ts b/src/components/Insights/SpanNexusInsight/mockData.ts similarity index 93% rename from src/components/Insights/CodeNexusInsight/mockData.ts rename to src/components/Insights/SpanNexusInsight/mockData.ts index eb6500f0c..8d8aea13a 100644 --- a/src/components/Insights/CodeNexusInsight/mockData.ts +++ b/src/components/Insights/SpanNexusInsight/mockData.ts @@ -1,11 +1,11 @@ import { InsightType } from "../../../types"; import { - CodeNexusInsight, InsightCategory, - InsightScope + InsightScope, + SpanNexusInsight } from "../types"; -export const mockedCodeNexusInsight: CodeNexusInsight = +export const mockedSpanNexusInsight: SpanNexusInsight = { firstDetected: "2023-12-05T17:25:47.010Z", lastDetected: "2024-01-05T13:14:47.010Z", @@ -17,7 +17,7 @@ export const mockedCodeNexusInsight: CodeNexusInsight = reopenCount: 0, ticketLink: null, name: "Code Nexus Point", - type: InsightType.CodeNexus, + type: InsightType.SpanNexus, category: InsightCategory.Usage, specifity: 2, importance: 3, diff --git a/src/components/Insights/CodeNexusInsight/styles.ts b/src/components/Insights/SpanNexusInsight/styles.ts similarity index 100% rename from src/components/Insights/CodeNexusInsight/styles.ts rename to src/components/Insights/SpanNexusInsight/styles.ts diff --git a/src/components/Insights/SpanNexusInsight/types.ts b/src/components/Insights/SpanNexusInsight/types.ts new file mode 100644 index 000000000..ee5a3f7f9 --- /dev/null +++ b/src/components/Insights/SpanNexusInsight/types.ts @@ -0,0 +1,9 @@ + +import { + InsightProps, + SpanNexusInsight, +} from "../types"; + +export interface SpanNexusInsightProps extends InsightProps { + insight: SpanNexusInsight; +} diff --git a/src/components/Insights/typeGuards.ts b/src/components/Insights/typeGuards.ts index 9dd7aad60..54eded626 100644 --- a/src/components/Insights/typeGuards.ts +++ b/src/components/Insights/typeGuards.ts @@ -1,7 +1,6 @@ import { InsightType } from "../../types"; import { ChattyApiEndpointInsight, - CodeNexusInsight, CodeObjectErrorsInsight, CodeObjectHotSpotInsight, CodeObjectInsight, @@ -22,6 +21,7 @@ import { SpanEndpointBottleneckInsight, SpanInsight, SpanNPlusOneInsight, + SpanNexusInsight, SpanScalingBadlyInsight, SpanScalingInsufficientDataInsight, SpanScalingWellInsight, @@ -135,7 +135,7 @@ export const isEndpointHighNumberOfQueriesInsight = ( ): insight is EndpointHighNumberOfQueriesInsight => insight.type === InsightType.EndpointHighNumberOfQueries; -export const isCodeNexusInsight = ( +export const isSpanNexusInsight = ( insight: CodeObjectInsight -): insight is CodeNexusInsight => - insight.type === InsightType.CodeNexus; +): insight is SpanNexusInsight => + insight.type === InsightType.SpanNexus; diff --git a/src/components/Insights/types.ts b/src/components/Insights/types.ts index 1cf83ae9c..e520c5573 100644 --- a/src/components/Insights/types.ts +++ b/src/components/Insights/types.ts @@ -683,8 +683,8 @@ export interface EndpointHighNumberOfQueriesInsight extends EndpointInsight { quantile?: number; } -export interface CodeNexusInsight extends SpanInsight { - type: InsightType.CodeNexus; +export interface SpanNexusInsight extends SpanInsight { + type: InsightType.SpanNexus; servicesCount: number; endpointsCount: number; flowsCount: number; diff --git a/src/utils/getInsightTypeInfo.ts b/src/utils/getInsightTypeInfo.ts index b4ded0bd9..76f7f4197 100644 --- a/src/utils/getInsightTypeInfo.ts +++ b/src/utils/getInsightTypeInfo.ts @@ -114,7 +114,7 @@ export const getInsightTypeInfo = ( icon: SQLDatabaseIcon, label: "High number of queries" }, - [InsightType.CodeNexus]: { + [InsightType.SpanNexus]: { icon: BottleneckIcon, // todo changes label: "Code Nexus Point" } From 759d4a7ee07719e954df06bd1be8dbc9cf8d49a3 Mon Sep 17 00:00:00 2001 From: olehp Date: Fri, 19 Jan 2024 14:13:08 +0200 Subject: [PATCH 3/8] rename --- src/types.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/types.ts b/src/types.ts index b9d5a2a8b..da8ad573d 100644 --- a/src/types.ts +++ b/src/types.ts @@ -32,7 +32,7 @@ export enum InsightType { EndpointSessionInView = "EndpointSessionInView", EndpointChattyApi = "EndpointChattyApi", EndpointHighNumberOfQueries = "EndpointHighNumberOfQueries", - CodeNexus = "CodeNexus", + SpanNexus = "SpanNexus", } export type PercentileKey = "p50" | "p95"; From 0444d2d7d0f4243a9540b983b43cfc9d856341bc Mon Sep 17 00:00:00 2001 From: olehp Date: Fri, 19 Jan 2024 16:23:36 +0200 Subject: [PATCH 4/8] fix contract --- src/components/Insights/SpanNexusInsight/index.tsx | 12 ++++++------ src/components/Insights/SpanNexusInsight/mockData.ts | 6 +++--- src/components/Insights/types.ts | 6 +++--- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/components/Insights/SpanNexusInsight/index.tsx b/src/components/Insights/SpanNexusInsight/index.tsx index d5fc6b800..c0a0d830d 100644 --- a/src/components/Insights/SpanNexusInsight/index.tsx +++ b/src/components/Insights/SpanNexusInsight/index.tsx @@ -7,31 +7,31 @@ import { SpanNexusInsightProps, } from "./types"; export const SpanNexusInsight = ( props: SpanNexusInsightProps ) => { - const { insight } = props; + const { insight } = props; return ( - Multiple code flows depned on this location + Multiple code flows depned on this location Services - + Edpoints - + Flows - + Usage - + diff --git a/src/components/Insights/SpanNexusInsight/mockData.ts b/src/components/Insights/SpanNexusInsight/mockData.ts index 8d8aea13a..c17ecd6c9 100644 --- a/src/components/Insights/SpanNexusInsight/mockData.ts +++ b/src/components/Insights/SpanNexusInsight/mockData.ts @@ -55,8 +55,8 @@ export const mockedSpanNexusInsight: SpanNexusInsight = "method:org.springframework.samples.petclinic.owner.PetController$_$processCreationForm", customStartTime: null, actualStartTime: "2023-08-10T08:04:00Z", - flowsCount :4, - servicesCount: 3, + flows :4, + services: 3, usage: 'High', - endpointsCount: 5, + endpoints: 5, }; diff --git a/src/components/Insights/types.ts b/src/components/Insights/types.ts index e520c5573..a9cfaac2e 100644 --- a/src/components/Insights/types.ts +++ b/src/components/Insights/types.ts @@ -685,9 +685,9 @@ export interface EndpointHighNumberOfQueriesInsight extends EndpointInsight { export interface SpanNexusInsight extends SpanInsight { type: InsightType.SpanNexus; - servicesCount: number; - endpointsCount: number; - flowsCount: number; + services: number; + endpoints: number; + flows: number; usage: string | null; } From 507b7f6034f19dc6e24df3258e7340ec46ef408d Mon Sep 17 00:00:00 2001 From: olehp Date: Fri, 19 Jan 2024 16:46:07 +0200 Subject: [PATCH 5/8] Fix contrat --- src/components/Insights/SpanNexusInsight/index.tsx | 9 +++++---- src/components/Insights/SpanNexusInsight/mockData.ts | 2 +- src/components/Insights/types.ts | 2 +- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/components/Insights/SpanNexusInsight/index.tsx b/src/components/Insights/SpanNexusInsight/index.tsx index c0a0d830d..cf415cbbb 100644 --- a/src/components/Insights/SpanNexusInsight/index.tsx +++ b/src/components/Insights/SpanNexusInsight/index.tsx @@ -8,6 +8,7 @@ export const SpanNexusInsight = ( props: SpanNexusInsightProps ) => { const { insight } = props; + const { entries, flows, usage, services } = insight; return ( Services - + Edpoints - + Flows - + Usage - + diff --git a/src/components/Insights/SpanNexusInsight/mockData.ts b/src/components/Insights/SpanNexusInsight/mockData.ts index c17ecd6c9..00f55d922 100644 --- a/src/components/Insights/SpanNexusInsight/mockData.ts +++ b/src/components/Insights/SpanNexusInsight/mockData.ts @@ -58,5 +58,5 @@ export const mockedSpanNexusInsight: SpanNexusInsight = flows :4, services: 3, usage: 'High', - endpoints: 5, + entries: 5, }; diff --git a/src/components/Insights/types.ts b/src/components/Insights/types.ts index a9cfaac2e..d6ff4875d 100644 --- a/src/components/Insights/types.ts +++ b/src/components/Insights/types.ts @@ -686,7 +686,7 @@ export interface EndpointHighNumberOfQueriesInsight extends EndpointInsight { export interface SpanNexusInsight extends SpanInsight { type: InsightType.SpanNexus; services: number; - endpoints: number; + entries: number; flows: number; usage: string | null; } From f73c5295ad166cd73b4fde4f6f77391643fab661 Mon Sep 17 00:00:00 2001 From: olehp Date: Fri, 19 Jan 2024 16:53:50 +0200 Subject: [PATCH 6/8] Added to list --- src/components/Insights/Insights.stories.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/components/Insights/Insights.stories.tsx b/src/components/Insights/Insights.stories.tsx index aeccb97d9..d0f5b9a3c 100644 --- a/src/components/Insights/Insights.stories.tsx +++ b/src/components/Insights/Insights.stories.tsx @@ -4,6 +4,7 @@ import { InsightType } from "../../types"; import { mockedBottleneckInsight } from "./BottleneckInsight/mockData"; import { mockedEndpointNPlusOneInsight } from "./EndpointNPlusOneInsight/mockData"; import { mockedHighNumberOfQueriesInsight } from "./HighNumberOfQueriesInsight/mockData"; +import { mockedSpanNexusInsight } from "./SpanNexusInsight/mockData"; import { CodeObjectErrorsInsight, ComponentType, @@ -707,7 +708,8 @@ export const Default: Story = { }, mockedEndpointNPlusOneInsight, mockedBottleneckInsight, - mockedHighNumberOfQueriesInsight + mockedHighNumberOfQueriesInsight, + mockedSpanNexusInsight ] } } From b473aca8952036ffbe694742c2000a44142e8d1c Mon Sep 17 00:00:00 2001 From: olehp Date: Mon, 22 Jan 2024 11:53:13 +0200 Subject: [PATCH 7/8] Change severity for fields --- src/components/Insights/SpanNexusInsight/index.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/components/Insights/SpanNexusInsight/index.tsx b/src/components/Insights/SpanNexusInsight/index.tsx index cf415cbbb..acd818455 100644 --- a/src/components/Insights/SpanNexusInsight/index.tsx +++ b/src/components/Insights/SpanNexusInsight/index.tsx @@ -20,7 +20,7 @@ export const SpanNexusInsight = ( Services - + Edpoints @@ -28,11 +28,11 @@ export const SpanNexusInsight = ( Flows - + Usage - + From c1aac9db0b9c98a513704033fc9f2dad09b78e1c Mon Sep 17 00:00:00 2001 From: olehp Date: Mon, 22 Jan 2024 11:57:25 +0200 Subject: [PATCH 8/8] fix typo --- src/components/Insights/SpanNexusInsight/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/Insights/SpanNexusInsight/index.tsx b/src/components/Insights/SpanNexusInsight/index.tsx index acd818455..48422d2f0 100644 --- a/src/components/Insights/SpanNexusInsight/index.tsx +++ b/src/components/Insights/SpanNexusInsight/index.tsx @@ -15,7 +15,7 @@ export const SpanNexusInsight = ( content={ - Multiple code flows depned on this location + Multiple code flows depend on this location