From 27bfce2d60a3fdd543bbf548ce2e492872c9e849 Mon Sep 17 00:00:00 2001 From: Kyrylo Shmidt Date: Thu, 29 Feb 2024 09:59:31 +0100 Subject: [PATCH 1/2] Add Duration insight --- .../InsightCard/ColumnsContainer/styles.ts | 2 +- .../Insights/common/InsightCard/index.tsx | 21 +- .../Insights/common/InsightCard/styles.ts | 1 + .../Insights/common/InsightCard/types.ts | 4 +- .../DurationInsight.stories.tsx | 5382 +++++++++++++++++ .../ReferenceLineLabel/index.tsx | 47 + .../ReferenceLineLabel/types.ts | 7 + .../DurationInsight/XAxisTick/index.tsx | 42 + .../DurationInsight/XAxisTick/types.ts | 9 + .../insights/DurationInsight/constants.ts | 2 + .../common/insights/DurationInsight/index.tsx | 438 ++ .../common/insights/DurationInsight/styles.ts | 33 + .../common/insights/DurationInsight/types.ts | 36 + src/components/common/App/themes/darkTheme.ts | 15 + .../common/App/themes/lightTheme.ts | 15 + src/components/common/v3/Tag/index.tsx | 7 +- src/styled.d.ts | 15 + 17 files changed, 6069 insertions(+), 7 deletions(-) create mode 100644 src/components/Insights/common/insights/DurationInsight/DurationInsight.stories.tsx create mode 100644 src/components/Insights/common/insights/DurationInsight/ReferenceLineLabel/index.tsx create mode 100644 src/components/Insights/common/insights/DurationInsight/ReferenceLineLabel/types.ts create mode 100644 src/components/Insights/common/insights/DurationInsight/XAxisTick/index.tsx create mode 100644 src/components/Insights/common/insights/DurationInsight/XAxisTick/types.ts create mode 100644 src/components/Insights/common/insights/DurationInsight/constants.ts create mode 100644 src/components/Insights/common/insights/DurationInsight/index.tsx create mode 100644 src/components/Insights/common/insights/DurationInsight/styles.ts create mode 100644 src/components/Insights/common/insights/DurationInsight/types.ts diff --git a/src/components/Insights/common/InsightCard/ColumnsContainer/styles.ts b/src/components/Insights/common/InsightCard/ColumnsContainer/styles.ts index fa0703a9b..32152c8b4 100644 --- a/src/components/Insights/common/InsightCard/ColumnsContainer/styles.ts +++ b/src/components/Insights/common/InsightCard/ColumnsContainer/styles.ts @@ -2,7 +2,7 @@ import styled from "styled-components"; export const Container = styled.div` display: flex; - gap: 8px; + gap: 24px; justify-content: space-between; flex-grow: 1; diff --git a/src/components/Insights/common/InsightCard/index.tsx b/src/components/Insights/common/InsightCard/index.tsx index 663691097..060671e2f 100644 --- a/src/components/Insights/common/InsightCard/index.tsx +++ b/src/components/Insights/common/InsightCard/index.tsx @@ -7,11 +7,11 @@ import { HistogramIcon } from "../../../common/icons/16px/HistogramIcon"; import { LiveIcon } from "../../../common/icons/16px/LiveIcon"; import { PinIcon } from "../../../common/icons/16px/PinIcon"; import { RecalculateIcon } from "../../../common/icons/16px/RecalculateIcon"; -import { CrossIcon } from "../../../common/icons/CrossIcon"; import { Button } from "../../../common/v3/Button"; import { Card } from "../../../common/v3/Card"; import { JiraButton } from "../../../common/v3/JiraButton"; import { Tooltip } from "../../../common/v3/Tooltip"; +import { isSpanInsight } from "../../typeGuards"; import { IconButton } from "./IconButton"; import { InsightHeader } from "./InsightHeader"; import * as s from "./styles"; @@ -35,6 +35,18 @@ export const InsightCard = (props: InsightCardProps) => { setIsRecalculatingStarted(true); }; + const handleHistogramButtonClick = () => { + isSpanInsight(props.insight) && + props.insight.spanInfo && + props.onOpenHistogram && + props.onOpenHistogram( + props.insight.spanInfo.instrumentationLibrary, + props.insight.spanInfo.name, + props.insight.type, + props.insight.spanInfo.displayName + ); + }; + const renderRecalculationBlock = ( actualStartTime: string, customStartTime: string | null, @@ -107,10 +119,13 @@ export const InsightCard = (props: InsightCardProps) => { } footer={ -