From db6d552dab9f7bb14a4a741f473157d0b4d4293e Mon Sep 17 00:00:00 2001 From: Kyrylo Shmidt Date: Sat, 30 Mar 2024 07:03:29 +0100 Subject: [PATCH] Unify insight naming --- .../jaeger-ui/src/components/common/InsightIcon/types.ts | 4 ++-- .../jaeger-ui/src/components/common/InsightIcon/utils.ts | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/jaeger-ui/src/components/common/InsightIcon/types.ts b/packages/jaeger-ui/src/components/common/InsightIcon/types.ts index 296d936f8d..ff94be7d8f 100644 --- a/packages/jaeger-ui/src/components/common/InsightIcon/types.ts +++ b/packages/jaeger-ui/src/components/common/InsightIcon/types.ts @@ -17,10 +17,10 @@ export enum InsightType { EndpointBottleneck = 'EndpointBottleneck', EndpointSpanNPlusOne = 'EndpointSpanNPlusOne', SpanUsages = 'SpanUsages', - SpanNPlusOne = 'SpaNPlusOne', + SpaNPlusOne = 'SpaNPlusOne', SpanEndpointBottleneck = 'SpanEndpointBottleneck', SpanDurations = 'SpanDurations', - SpanScalingBadly = 'SpanScaling', + SpanScaling = 'SpanScaling', SpanDurationBreakdown = 'SpanDurationBreakdown', EndpointBreakdown = 'EndpointBreakdown', EndpointSessionInView = 'EndpointSessionInView', diff --git a/packages/jaeger-ui/src/components/common/InsightIcon/utils.ts b/packages/jaeger-ui/src/components/common/InsightIcon/utils.ts index 04c4945164..ebaa0c63cb 100644 --- a/packages/jaeger-ui/src/components/common/InsightIcon/utils.ts +++ b/packages/jaeger-ui/src/components/common/InsightIcon/utils.ts @@ -62,7 +62,7 @@ export const getInsightTypeInfo = ( icon: SQLDatabaseIcon, label: 'Suspected N+1', }, - [InsightType.SpanNPlusOne]: { + [InsightType.SpaNPlusOne]: { icon: SQLDatabaseIcon, label: 'Suspected N+1', }, @@ -70,7 +70,7 @@ export const getInsightTypeInfo = ( icon: BottleneckIcon, label: 'Bottleneck', }, - [InsightType.SpanScalingBadly]: { + [InsightType.SpanScaling]: { icon: ScalesIcon, label: 'Scaling Issue Found', }, @@ -175,8 +175,8 @@ export const getInsightTypeOrderPriority = (type: string): number => { // Span insights [InsightType.SpanDurations]: 60, [InsightType.SpanUsages]: 61, - [InsightType.SpanScalingBadly]: 63, - [InsightType.SpanNPlusOne]: 65, + [InsightType.SpanScaling]: 63, + [InsightType.SpaNPlusOne]: 65, [InsightType.SpanEndpointBottleneck]: 67, [InsightType.SpanDurationBreakdown]: 68, [InsightType.SpanNexus]: 69,