From def9e45cce93e91ec5e59199bb3bb029a65cd311 Mon Sep 17 00:00:00 2001
From: Kyrylo Shmidt <kshmidt@digma.ai>
Date: Mon, 15 May 2023 10:37:17 +0200
Subject: [PATCH 1/2] Make spans without code locations clickable

---
 .../TracePage/TraceTimelineViewer/SpanDetail/index.tsx    | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetail/index.tsx b/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetail/index.tsx
index 1ada2527f7..a358825cb2 100644
--- a/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetail/index.tsx
+++ b/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetail/index.tsx
@@ -27,7 +27,7 @@ import LabeledList from '../../../common/LabeledList';
 import { actions } from '../../../../api/digma/actions';
 import { dispatcher } from '../../../../api/digma/dispatcher';
 import { state as globalState } from '../../../../api/digma/state';
-import { SetSpansDataPayload } from '../../../../api/digma/types';
+import { ISpanInsight, SetSpansDataPayload } from '../../../../api/digma/types';
 import { getInsightTypeInfo } from '../../../common/InsightIcon/utils';
 import { InsightIcon } from '../../../common/InsightIcon';
 
@@ -51,7 +51,6 @@ type SpanDetailProps = {
 };
 
 type SpanDetailState = {
-  hasCodeLocation: boolean;
   insights: ISpanInsight[];
 };
 
@@ -60,7 +59,6 @@ export default class SpanDetail extends React.Component<SpanDetailProps, SpanDet
     super(props);
     const span = globalState.spans[props.span.spanID];
     this.state = {
-      hasCodeLocation: Boolean(span && span.hasCodeLocation),
       insights: span ? span.insights : [],
     };
   }
@@ -77,7 +75,6 @@ export default class SpanDetail extends React.Component<SpanDetailProps, SpanDet
   updateSpanInfo = (data: unknown) => {
     const span = (data as SetSpansDataPayload)[this.props.span.spanID];
     this.setState({
-      hasCodeLocation: Boolean(span && span.hasCodeLocation),
       insights: span ? span.insights : [],
     });
   };
@@ -137,12 +134,13 @@ export default class SpanDetail extends React.Component<SpanDetailProps, SpanDet
       },
     ];
     const deepLinkCopyText = `${window.location.origin}${window.location.pathname}?uiFind=${spanID}`;
+    const otelLibraryNameTag = this.props.span.tags.find((tag: any) => tag.key === 'otel.library.name');
 
     return (
       <div>
         <div className="SpanDetail--header">
           <div className="ub-flex ub-items-center">
-            {this.state.hasCodeLocation ? (
+            {otelLibraryNameTag ? (
               <RouterLink
                 to="#"
                 onClick={this.handleGoToCodeLinkClick}

From 265a88cfbaf3ad51336405577fa08c838ce7ea0a Mon Sep 17 00:00:00 2001
From: Kyrylo Shmidt <kshmidt@digma.ai>
Date: Mon, 15 May 2023 17:33:17 +0200
Subject: [PATCH 2/2] Make spans clickable only if they have insights

---
 .../TracePage/TraceTimelineViewer/SpanDetail/index.tsx          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetail/index.tsx b/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetail/index.tsx
index a358825cb2..541e401664 100644
--- a/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetail/index.tsx
+++ b/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetail/index.tsx
@@ -140,7 +140,7 @@ export default class SpanDetail extends React.Component<SpanDetailProps, SpanDet
       <div>
         <div className="SpanDetail--header">
           <div className="ub-flex ub-items-center">
-            {otelLibraryNameTag ? (
+            {otelLibraryNameTag && this.state.insights.length > 0 ? (
               <RouterLink
                 to="#"
                 onClick={this.handleGoToCodeLinkClick}