drop unnecessary sync marker #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dignifiedquire Any thoughts on this? |
dignifiedquire
approved these changes
Jul 23, 2021
|
Thanks! Unfortunately I can't merge unless you'd like to add me as a maintainer, happy to help getting a release out. |
|
Great, thanks for pushing out a release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precipitated by this change: rusoto/rusoto#1896 which eventually propagates to our package here: https://github.com/swift-nav/esthri/blob/master/src/esthri/src/http_server.rs#L346 and causes a compile error because
.append_datarequires the stream to be Send+Sync. Dropping the Sync marker seems to work here, assuming that it isn't actually needed for some other reason?And FWIW, this was encountered while updating Rusoto here: https://github.com/swift-nav/esthri/pull/184/files -- our package combines types from rusoto and async-tar.