Fix Issue #23: DigraphMaximalCliques #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I'm going to merge this when the tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DigraphMaximalCliquesandDigraphMaximalCliquesRepsused to be slow when the digraph in question had lots of isolated vertices. This is because the subgroup of the automorphism group which acts on these vertices is the symmetric group, which is really big. Therefore calculations involving the automorphism group were taking ages. All of the time was spent calculating stabilizer chains, etc.Now, in certain cases when it is safe to do so, we (in essence) remove the isolated vertices (except one), and remove the generators of the automorphism group which act on the isolated vertices. This speeds things up.