Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magnitudes for openCL #10

Closed
Carolina710 opened this issue Nov 25, 2020 · 6 comments
Closed

Magnitudes for openCL #10

Carolina710 opened this issue Nov 25, 2020 · 6 comments
Labels
question Further information is requested

Comments

@Carolina710
Copy link

Hello, do you have any idea when the magnitude calculation for the openCL version will be available?

I'm using the y_error and the ns values that are returned from bfastfinaldetailed, but it takes some time to do the calculation on the CPU, as well as a large allocation of GPU memory necessary to perform the bfastfinaldetailed. I have already looked at the bfastfinal and bfastfinaldetailed files a lot, trying to understand which kernels do what, but they are very unreadable.
I saw that you made commits to the opencl-backend-debug branch with work for magnitude calculation for the openCL, but I was unable to use the updates.

Thank you!

@mortvest
Copy link
Collaborator

mortvest commented Nov 25, 2020

Hi Carolina,

There has been a lot of changes to the OpenCL version, and we are working on tuning its performance and it would take a while.
In a meantime you can use opencl-backend-debug branch. It supports the magnitudes for both the OpenCL and Python backends. What problems are you experiencing with the update?

@mortvest mortvest added the question Further information is requested label Nov 25, 2020
@Carolina710
Copy link
Author

Thank you for the rapid response.

I just used your peru_small_opencl example. The error occurs in the openCL version:

image

I wonder if it is not related to the _get_futhark_params function, that is returning null?

image

Thank you! :)

@mortvest
Copy link
Collaborator

That looks like an internal OpenCL problem. _get_futhark_params() should not be a problem, since returns an empty dictionary here, hence no tuning is applied. I don't get this error when running the peru_small_opencl.py and it runs fine for me.
What GPU are you using?

@mortvest mortvest added the bug Something isn't working label Nov 25, 2020
@Carolina710
Copy link
Author

Hello,

My GPU is quit of lower performance:

image

After your response, I take some time to run the code on a remote PC that I have access and all works fine. 👍

image

Thank you!

@mortvest
Copy link
Collaborator

No problem. I have also experienced similar issues with my old laptop after we have changed the indexing to 64-bit integers.

@mortvest mortvest removed the bug Something isn't working label Nov 30, 2020
@mortvest
Copy link
Collaborator

OpenCL magnitude support has been added to develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants