Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stable period determination not implemented #44

Open
fnands opened this issue Mar 28, 2022 · 2 comments
Open

Stable period determination not implemented #44

fnands opened this issue Mar 28, 2022 · 2 comments

Comments

@fnands
Copy link

fnands commented Mar 28, 2022

Hi,

I had a look at the python version and if I'm not mistaken a stable history period is never determined as in section 2.4 of the paper.

Am I correct, or did I misunderstand the code? I tried to read the futhark implementation and it doesn't seem to be there either.
@fnands
Copy link
Author

fnands commented Apr 7, 2022

Oh, I see there is a PR by @nhey that implements it. Can it be merged?

@mortvest
Copy link
Collaborator

mortvest commented May 4, 2022 •
edited
Loading

I don't have the time to test the ROC implementation right now. Have you tried using the branch?
I am planning a big overhaul of the whole package in the near future, and it will be included there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fnands @mortvest