New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset#update #13

Closed
agisga opened this Issue Jun 20, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@agisga
Contributor

agisga commented Jun 20, 2015

  1. Examples in the comment to Dataset#update don't match the behaviour of the method.
    I think either the method definition should be update(data: nil, **options) (instead of data = nil), or the syntax in the examples should be in_memory_points.update(some_update, title: 'Updated') (instead of data: some_update).
  2. I don't see the purpose of the line temp_file_points = Dataset.new(points, title: 'Old one', file: true) in the examples.
  3. Additionally, if I do:
> db = Datablock.new([1,2,3])
> d = Dataset.new(db)
> d.update([4,5,6])
=> #<Gnuplot::Dataset:0x007feed8c68e18
 @data=
  #<Gnuplot::Datablock:0x007feed8c683a0
   @data="1\n2\n34\n5\n6",
   @stored_in_file=false>,
 @options=Hamster::Hash[],
 @type=:datablock>

Shouldn't there be a "\n" in between 3 and 4, or do I understand something wrong?

@dilcom

This comment has been minimized.

Owner

dilcom commented Jun 20, 2015

1-2. You're right, docs for Dataset#update is mix of correct examples and examples for Plot#update_dataset. Will fix it.

  1. It's a bug. Thank you!

@dilcom dilcom added this to the 0.1.2 milestone Jun 20, 2015

@dilcom dilcom added the bug label Jun 20, 2015

dilcom added a commit that referenced this issue Jun 20, 2015

dilcom added a commit that referenced this issue Jun 20, 2015

@dilcom dilcom closed this Jun 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment