Management commands #29600
Draft
Management commands #29600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaapstorm
requested review from
dannyroberts,
millerdev,
mjriley,
orangejenny and
gherceg
stickler-ci
reviewed
Apr 23, 2021
| repeater_id: Optional[str] = None, | ||
| states: Optional[List[str]] = None, | ||
| order_by: Optional[List[str]] = None, | ||
| ) -> Tuple[Iterator['SQLRepeatRecord'], int]: |
There was a problem hiding this comment.
F821 undefined name 'SQLRepeatRecord'
| queryset: QuerySet, | ||
| record_count: int, | ||
| chunk_size: int = 1000, | ||
| ) -> Iterator['SQLRepeatRecord']: |
There was a problem hiding this comment.
F821 undefined name 'SQLRepeatRecord'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Repeat Records Couch-to-SQL migration PR 5 of 6
See PR #29599 for more context.
The work I intended for this branch is not complete. There is a commit missing after "Update update_cancelled_records command" and before "Command to revert RepeatRecord migration" to update broken tests.
Safety Assurance
Automated test coverage
Test coverage for this PR is not complete.
QA Plan
Left to the discretion of the SaaS team.
Safety story
This PR will be subject to change. It is not safe to merge.
Rollback instructions