Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple version of the optional glam conversion #900

Merged
merged 2 commits into from Jun 1, 2021

Conversation

@sebcrozet
Copy link
Member

@sebcrozet sebcrozet commented Jun 1, 2021

This removes the convert-glam and convert-glam-unchecked features.
Instead, this adds the convert-glam013, convert-glam014, and convert-glam015 features for conversions targeting the versions 0.13, 0.14, and 0.15 of glam.

With this change of features naming, we can provide conversions for multiple versions of glam, and a major version bump for glam will no longer require a major version bump for nalgebra.

The conversions behind the convert-glam-unchecked feature have been replaced by TryFrom impls or conversions that transform the input to generate a valid output.

@sebcrozet sebcrozet merged commit de705a8 into dev Jun 1, 2021
9 checks passed
9 checks passed
@github-actions
check-fmt
Details
@github-actions
clippy
Details
@github-actions
build-nalgebra
Details
@github-actions
test-nalgebra
Details
@github-actions
test-nalgebra-glm
Details
@github-actions
test-nalgebra-sparse
Details
@github-actions
test-nalgebra-macros
Details
@github-actions
build-wasm
Details
@github-actions
build-no-std
Details
@sebcrozet sebcrozet deleted the glam-multiversion branch Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant