Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Feb 21, 2014
  1. @DarwinAwardWinner

    Clean up whitespace

    DarwinAwardWinner authored
    This commit is the result of running
    Fixes #549.
Commits on Mar 18, 2012
  1. @DarwinAwardWinner

    Merge branch 'compile-after-build'

    DarwinAwardWinner authored
Commits on Mar 8, 2012
  1. @DarwinAwardWinner
Commits on Feb 27, 2012
  1. @DarwinAwardWinner
Commits on Feb 26, 2012
  1. @DarwinAwardWinner
  2. @DarwinAwardWinner

    Always run el-get-compile-process

    DarwinAwardWinner authored
    Since el-get-byte-compile-process now does stale elc cleaning, it
    needs to be run even if there's nothing to compile.
  3. @DarwinAwardWinner

    Compute byte-compile list after build

    DarwinAwardWinner authored
    This ensures that files created during the build process can be
    byte-compiled in the byte-compile step.
Commits on Feb 25, 2012
  1. @DarwinAwardWinner
  2. @DarwinAwardWinner
Commits on Feb 11, 2012
  1. @DarwinAwardWinner

    Fix el-get-build always running synchronously

    DarwinAwardWinner authored
    The problem was that the "sync" symbol was inside a backquote and was
    not comma-prefixed, so the ":sync" property was getting set literall
    to the symbol "'sync" instead of its value. Obviously, "'sync" is a
    true value, so the commands were all run synchronously.
    Fixes #307.
    Fixes #385.
Commits on Oct 7, 2011
  1. @DarwinAwardWinner
  2. @DarwinAwardWinner
  3. @DarwinAwardWinner

    Don't assume that first build command is a string

    DarwinAwardWinner authored
    Build commands are supposed to be either strings or lists of strings.
    But the code for deciding whether to eval the :build property only
    checks for a string, not a list. This commit fixes this, so that a
    build property whose commands are all lists of strings should no
    longer cause an error. Evaluation of the :build property now only
    happens when the car is a symbol, since that is the only time that
    evaluation would not result in an error.
    Also in this commit:
    * Ensure build commands are all strings or lists of strings and raise
      an error otherwise. The check happens after flattening, so nested
      lists of strings should also pass.
    * A few syntax fixes
    * Add a function "el-get-list-of-strings-p"
Commits on Oct 6, 2011
  1. @DarwinAwardWinner

    Warn for build commands that rely on whitespace-splitting

    DarwinAwardWinner authored
    El-get-build allows a command to be specified as a single string. It
    will split that string on whitespace into a list of strings, and each
    element of that list will eventually be shell-quoted (by
    `el-get-start-process-list`). This is wrong behavior that can easily
    cause an innocent command to be over-escaped or split into too many
    arguments, or both. For example, consider a build process that
    involves running the following command:
        make SOME_OPTION="this is the option value"
    Written as a string in Elisp, that would be:
        "make SOME_OPTION=\"this is the option value\""
    After splitting on whitespace and then shell-quoting and then passing
    the result to the shell, the above command is equivalent to running
    the following at the shell:
        "make" "SOME_OPTION=\"this" "is" "the" "option" "value\""
    See the problem? What was once a single argument is now five, and the
    quotation marks have been inappropriately quoted. For this reason, I
    think auto-whitespace splitting should probably be deprecated. The
    command should either be a single string, which would be interpreted
    as a command to be run with no arguments, or a list of strings, like
        '("make" "SOME_OPTION=\"this is the option value\"")
  2. @DarwinAwardWinner

    Use a list of arguments instead of a single string for command

    DarwinAwardWinner authored
    The `el-get-install-or-init-info` composed a command as a single
    pre-quoted string using `concat` and `shell-quote-argument`. It is
    better to make the command a list of unquoted arguments, which is what
    this commit does.
Commits on Oct 5, 2011
  1. @DarwinAwardWinner

    Don't call shell-quote-argument in el-get-build

    DarwinAwardWinner authored
    Also, use slightly more robust type checking on the command.
Something went wrong with that request. Please try again.