`el-get-executable-find` throws an error when not found, should it just return nil? #1830

Closed
dimitri opened this Issue Jul 21, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@dimitri
Owner

dimitri commented Jul 21, 2014

As seen in dimitri/emacs-kicker#6, I think it might be wise for el-get-executable-find to actually return nil... but I might be missing something and I didn't take time to match my impression with actual code...

@npostavs

This comment has been minimized.

Show comment Hide comment
@npostavs

npostavs Jul 21, 2014

Collaborator

It was introduced in 88f1faf, with the intent that it should throw a meaningful error (you don't have x installed) rather than a package installation failing for a somewhat mysterious reason.

You could use (ignore-errors (el-get-executable-find "foo")), or (executable-find "foo") (although that wouldn't check el-get-foo-executable), or else we could add a noerror parameter to el-get-executable-find.

Collaborator

npostavs commented Jul 21, 2014

It was introduced in 88f1faf, with the intent that it should throw a meaningful error (you don't have x installed) rather than a package installation failing for a somewhat mysterious reason.

You could use (ignore-errors (el-get-executable-find "foo")), or (executable-find "foo") (although that wouldn't check el-get-foo-executable), or else we could add a noerror parameter to el-get-executable-find.

@dimitri

This comment has been minimized.

Show comment Hide comment
@dimitri

dimitri Jul 22, 2014

Owner

I just hacked my way using ignore-errors, thanks for the comment, makes sense.

Owner

dimitri commented Jul 22, 2014

I just hacked my way using ignore-errors, thanks for the comment, makes sense.

@dimitri dimitri closed this Jul 22, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment