error in process sentinel

[dabrahams]

The following reproduces the error.

(setq el-get-sources
      '((:name xmlunicode :depends
               (unichars)
               :type http :url "http://nwalsh.com/emacs/xmlchars/xmlunicode.el")
        (:name unichars :type http :url "http://nwalsh.com/emacs/xmlchars/unichars.el")))
(setq debug-ignored-errors '())
(setq debug-on-error t)
(el-get-install "xmlunicode")

I strongly suspect this is due to a different instance of the same kind of problem being addressed in this pull request.

One way to be more truly safe is to avoid lambdas and use apply-partially with real functions.

[dimitri]

Fail to reproduce with following script, will try again later:

;; https://github.com/dimitri/el-get/issues/303
;;
;; error in process sentinel

(let ((debug-on-error t)
      (debug-ignored-errors '()))
  (add-to-list 'load-path "/Users/dim/dev/emacs/el-get")
  (require 'el-get)
  (setq el-get-byte-compile nil
    el-get-verbose t
    el-get-sources
    '((:name xmlunicode :depends
         (unichars)
         :type http :url "http://nwalsh.com/emacs/xmlchars/xmlunicode.el")
      (:name unichars :type http :url "http://nwalsh.com/emacs/xmlchars/unichars.el")))
  (el-get-install "xmlunicode"))

What I get is:

dim ~/dev/temp rm -rf /tmp/test/
dim ~/dev/temp mkdir -p /tmp/test/.emacs.d/el-get                                                                     
dim ~/dev/temp HOME=/tmp/test /Applications/Emacs.app/Contents/MacOS/Emacs -Q -batch -l el-get-issue-303.el
Contacting host: nwalsh.com:80
el-get install unichars

That needs more attention than I have now.

[dabrahams]

why did you not try with the script I provided? setting el-get-byte-compile to nil, among other things, changes the test case.

[dimitri]

I was just trying to adapt to my usual debug scripts, and missed this byte-compile line when doing so. Reverted, I now have:

dim ~/dev/temp HOME=/tmp/test /Applications/Emacs.app/Contents/MacOS/Emacs -Q -batch -l el-get-issue-303.el             
Warning: defvar ignored because el-get-verbose is let-bound
Warning: defvar ignored because el-get-sources is let-bound
Warning: defvar ignored because el-get-default-process-sync is let-bound
Contacting host: nwalsh.com:80
Saving file /tmp/test/.emacs.d/el-get/unichars/unichars.el.part...
Wrote /tmp/test/.emacs.d/el-get/unichars/unichars.el.part
Wrote /tmp/test/.emacs.d/el-get/unichars/unichars.el
el-get-build unichars
el-get is waiting for "byte-compile" to complete
"Debug on Error enabled globally
Lisp expression: el-get-byte-compile-from-stdin: /tmp/test/.emacs.d/el-get/unichars
Checking /tmp/test/.emacs.d/el-get/unichars...
Compiling /tmp/test/.emacs.d/el-get/unichars/unichars.el...
Wrote /tmp/test/.emacs.d/el-get/unichars/unichars.elc
Done (Total of 1 file compiled)
"
el-get: el-get-build unichars: byte-compile ok.
el-get-init: unichars
el-get initialized package unichars
Contacting host: nwalsh.com:80
Saving file /tmp/test/.emacs.d/el-get/xmlunicode/xmlunicode.el.part...
Wrote /tmp/test/.emacs.d/el-get/xmlunicode/xmlunicode.el.part
Wrote /tmp/test/.emacs.d/el-get/xmlunicode/xmlunicode.el
el-get-build xmlunicode
el-get is waiting for "byte-compile" to complete
"Debug on Error enabled globally
Lisp expression: el-get-byte-compile-from-stdin: /tmp/test/.emacs.d/el-get/xmlunicode
Checking /tmp/test/.emacs.d/el-get/xmlunicode...
Compiling /tmp/test/.emacs.d/el-get/xmlunicode/xmlunicode.el...
Wrote /tmp/test/.emacs.d/el-get/xmlunicode/xmlunicode.elc
Done (Total of 1 file compiled)
"
el-get: el-get-build xmlunicode: byte-compile ok.
el-get-init: xmlunicode
el-get initialized package xmlunicode
el-get install xmlunicode
el-get install unichars

Please note that I have to edit your test case for it to run here (or it won't find the el-get-install function).

[dabrahams]

I can't reproduce the problem either; I think it was addressed by your "is-it-a-symbol?" dance in the lambda