New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emacsmirror #232

Closed
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@glasserc
Contributor

glasserc commented May 27, 2011

This branch adds an alias to make it easier to define emacsmirror packages. (:name XXX :type emacsmirror) is equivalent to (:name XXX :type git :url "https://github.com/emacsmirror/XXX.git").

I also added a couple packages that I have in my own el-get-sources, and retrofitted existing packages.

Please apply.

Ethan

@dimitri

This comment has been minimized.

Show comment
Hide comment
@dimitri

dimitri Jun 19, 2011

Owner

Thanks for your work, and sorry for the late review!

I would apply your changes but have those 2 items we need to fix:

  • the emacsmirror http URL should be a defcustom (see the emacswiki one)
  • I don't think your change for color-theme-zenburn will work, or did I miss something?
Owner

dimitri commented Jun 19, 2011

Thanks for your work, and sorry for the late review!

I would apply your changes but have those 2 items we need to fix:

  • the emacsmirror http URL should be a defcustom (see the emacswiki one)
  • I don't think your change for color-theme-zenburn will work, or did I miss something?
@glasserc

This comment has been minimized.

Show comment
Hide comment
@glasserc

glasserc Jun 20, 2011

Contributor

OK, agreed on both counts.

Contributor

glasserc commented Jun 20, 2011

OK, agreed on both counts.

@dimitri dimitri closed this Jun 20, 2011

@dimitri

This comment has been minimized.

Show comment
Hide comment
@dimitri

dimitri Jun 20, 2011

Owner

Thanks for the update! Unfortunately I missed another set of changes to be done: the git URL should use the http or https protocol (firewall friendly) and should be a defcustom rather than a defvar (deprecated or soon to be, IIUC), and I think the sunrise series should be merged into a single recipe (at least I've seen that emacsmirror now does it this way).

Can you update your branch yet again, and ideally squeeze all those patches together so that I merge a single one? Thanks!

Owner

dimitri commented Jun 20, 2011

Thanks for the update! Unfortunately I missed another set of changes to be done: the git URL should use the http or https protocol (firewall friendly) and should be a defcustom rather than a defvar (deprecated or soon to be, IIUC), and I think the sunrise series should be merged into a single recipe (at least I've seen that emacsmirror now does it this way).

Can you update your branch yet again, and ideally squeeze all those patches together so that I merge a single one? Thanks!

@glasserc

This comment has been minimized.

Show comment
Hide comment
@glasserc

glasserc Jun 24, 2011

Contributor

It uses https now, doesn't it? What do you mean "http or https"? That this be a customize option?

Where did you hear about defvar being deprecated?

I'll work on the other stuff.

Contributor

glasserc commented Jun 24, 2011

It uses https now, doesn't it? What do you mean "http or https"? That this be a customize option?

Where did you hear about defvar being deprecated?

I'll work on the other stuff.

@dimitri

This comment has been minimized.

Show comment
Hide comment
@dimitri

dimitri Jun 24, 2011

Owner

On the protocol, I meant pick the one that works :) About defvar, it's use with M-x set-variable for user editable settings is deprecated by custom, I think. Thanks for your continued effort :)

Owner

dimitri commented Jun 24, 2011

On the protocol, I meant pick the one that works :) About defvar, it's use with M-x set-variable for user editable settings is deprecated by custom, I think. Thanks for your continued effort :)

@glasserc

This comment has been minimized.

Show comment
Hide comment
@glasserc

glasserc Jun 30, 2011

Contributor

I see that the sunrise merge was done by someone else. Do you mean that el-get should choose the protocol dynamically based on what works? All the old recipes use https or git. Do firewalls tend to block https but allow http? I'm still not sure exactly what you want.

Contributor

glasserc commented Jun 30, 2011

I see that the sunrise merge was done by someone else. Do you mean that el-get should choose the protocol dynamically based on what works? All the old recipes use https or git. Do firewalls tend to block https but allow http? I'm still not sure exactly what you want.

@dimitri

This comment has been minimized.

Show comment
Hide comment
@dimitri

dimitri Jul 13, 2011

Owner

Sorry about being that unclear: if http works, let's use that. If not, https. But that's static in the recipe file as of now. We tend not to use git if http(s) is available to be nice to places where they are not granted git://

Owner

dimitri commented Jul 13, 2011

Sorry about being that unclear: if http works, let's use that. If not, https. But that's static in the recipe file as of now. We tend not to use git if http(s) is available to be nice to places where they are not granted git://

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment