Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Do not save removed package to el-get-status-file. #907

Merged
merged 1 commit into from

3 participants

@renard

Signed-off-by: Sébastien Gross

Sébastien Gross Do not save removed package to el-get-status-file.
Signed-off-by: Sébastien Gross <seb•ɑƬ•chezwam•ɖɵʈ•org>
0e1d2d2
@DarwinAwardWinner
Collaborator

Any particular reason you want this? Or just to keep the status file neat and tidy?

@dimitri, was there any reason you designed it to save removed status into the status file in the first place?

@dimitri
Owner

No reason other than I hate loosing data I did have at some point, as a DBA kind of guy. Now, keeping the status file lean and clean is a good goal.

@renard

unlike dimitri like an SysAdim guy I like stuff to be clean and neat.

More seriously I do not see the point of keeping removed package information. But if you do have a good reason to do so, please just ignore the patch.

@dimitri dimitri merged commit f2a3b5b into from
@renard renard deleted the branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 3, 2012
  1. Do not save removed package to el-get-status-file.

    Sébastien Gross authored
    Signed-off-by: Sébastien Gross <seb•ɑƬ•chezwam•ɖɵʈ•org>
This page is out of date. Refresh to see the latest.
Showing with 7 additions and 3 deletions.
  1. +7 −3 el-get-status.el
View
10 el-get-status.el
@@ -58,9 +58,13 @@
(package-status-alist
(assq-delete-all package (el-get-read-status-file)))
(new-package-status-alist
- (sort (append package-status-alist
- (list ; alist of (PACKAGE . PROPERTIES-LIST)
- (cons package (list 'status status 'recipe recipe))))
+ (sort
+ ;; Do not save package information if status is removed.
+ (if (string= status "removed")
+ package-status-alist
+ (append package-status-alist
+ (list ; alist of (PACKAGE . PROPERTIES-LIST)
+ (cons package (list 'status status 'recipe recipe)))))
(lambda (p1 p2)
(string< (el-get-as-string (car p1))
(el-get-as-string (car p2)))))))
Something went wrong with that request. Please try again.