This repository has been archived by the owner on Oct 18, 2019. It is now read-only.
Clean up and simplify Go pipeline example. #31
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit cleans up a few things about the Go pipeline:
sync.WaitGroup
instead of atomic counter forrendezvous.
needn't be synchronous.
routines since the scheduler will self-bound their operation
per the maximum processors.
and replace it with a channel that merely contains the
neighborhood name. Neighborhood processing occurs in-flight
with the mappers.
efficient by prima facie rejecting candidates whose values are
too short to contain the needle.
routines.
Overall this change is performance neutral to being an improvement.
In my local runs, I was able to shave off about 2.5 seconds on the
substring run with this.