Skip to content
This repository has been archived by the owner. It is now read-only.

Solving the issue of empty attribute values #410

Merged
merged 1 commit into from Jan 4, 2018

Conversation

@saidbakr
Copy link
Contributor

commented Oct 9, 2017

When the model_translations table is empty or the related key from the models table is not assigned yet, i.e not translated, the original attribute value is returned as null so there is no text! This is a proposed solution for that issue.

Solving the issue of empty attribute values
When the `model_translations` table is empty or the related key from the `models` table is not assigned yet, i.e not translated, the original attribute value is returned as `null` so there is no text! This is a proposed solution for that issue.
@drbyte

This comment has been minimized.

Copy link

commented Oct 9, 2017

Another tip:
If you add "Fixes #409" or "Closes #409" in your Pull Request, it will automatically close the related Issue ticket when the Pull Request is merged. One less step for you or maintainers to manage. ;)

@dimsav

This comment has been minimized.

Copy link
Owner

commented Jan 4, 2018

I want to merge this but we need tests.

I added a test. Thanks!

@dimsav dimsav merged commit 1ab239b into dimsav:master Jan 4, 2018

1 check passed

continuous-integration/styleci/pr The StyleCI analysis has passed
Details
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.