Skip to content
This repository has been archived by the owner. It is now read-only.

fire saving event in every case #457

Merged
merged 1 commit into from Jun 27, 2018

Conversation

@Gummibeer
Copy link
Collaborator

commented May 7, 2018

solves #456

The normal laravel save method fires saving in every case - independent of dirty or anything else. This shouldn't be changed.

@Gummibeer

This comment has been minimized.

Copy link
Collaborator Author

commented May 7, 2018

StyleCI is fixed in #458

@dimsav

This comment has been minimized.

Copy link
Owner

commented Jun 27, 2018

I wonder if there is a way to test this.

@Gummibeer

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 27, 2018

Just if you create a listener for this and put an assertion in the listener - not sure if this is possible.

@Gummibeer Gummibeer self-assigned this Jun 27, 2018

@dimsav

This comment has been minimized.

Copy link
Owner

commented Jun 27, 2018

I remember it was a pain to test this. Let's merge.

@Gummibeer Gummibeer merged commit f72764e into dimsav:master Jun 27, 2018

1 check failed

continuous-integration/styleci/pr The analysis was misconfigured with 1 file
Details

@Gummibeer Gummibeer deleted the Gummibeer:patch-2 branch Jun 27, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.