New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mousemove show/hide controls should target pswp container not window/document #1547

Open
haroldus- opened this Issue Jul 27, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@haroldus-

haroldus- commented Jul 27, 2018

If you implement PhotoSwipe "inline", the controls show whenever the mouse is moved wherever in the window - this doesn't make sense if the user is focusing on some other aspect of the page.

It would be nicer if the controls showed only when the user's mouse is focused on the pswp container.

Is there any reason why you wouldn't target the container? It seems as if targeting the container would have the desired effect irrespective of the value of the modal option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment