Skip to content

Migrate resource ec_deployment_extension to terraform-plugin-framework - #12

Merged
pascal-hofmann merged 2 commits into
feature/530/migrate-to-plugin-frameworkfrom
feature/530/extensionresource
Oct 18, 2022
Merged

pascal-hofmann merged 2 commits into
feature/530/migrate-to-plugin-frameworkfrom
feature/530/extensionresource

Conversation

@pascal-hofmann

Copy link
Copy Markdown
Collaborator

Migrate resource ec_deployment_extension to terraform-plugin-framework

Description

Related Issues

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@pascal-hofmann
pascal-hofmann marked this pull request as ready for review September 27, 2022 06:27
Comment thread ec/ecresource/extensionresource/create.go
@pascal-hofmann
pascal-hofmann force-pushed the feature/530/extensionresource branch from 25045c4 to 28a9383 Compare September 28, 2022 06:52
@pascal-hofmann
pascal-hofmann marked this pull request as draft September 28, 2022 06:56
@pascal-hofmann
pascal-hofmann force-pushed the feature/530/extensionresource branch from 28a9383 to 64cd8cc Compare September 28, 2022 07:08
@pascal-hofmann
pascal-hofmann force-pushed the feature/530/extensionresource branch from 64cd8cc to 26bfdbc Compare September 28, 2022 07:15
@pascal-hofmann
pascal-hofmann marked this pull request as ready for review September 28, 2022 08:13
@pascal-hofmann

Copy link
Copy Markdown
Collaborator Author

@dimuon Can this be merged?

@dimuon dimuon left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dimuon

dimuon commented Sep 29, 2022

Copy link
Copy Markdown
Owner

@pascal-hofmann , please feel free to squash and merge it.

@pascal-hofmann
pascal-hofmann merged commit f310127 into feature/530/migrate-to-plugin-framework Oct 18, 2022
@pascal-hofmann
pascal-hofmann deleted the feature/530/extensionresource branch October 18, 2022 15:46
dimuon pushed a commit that referenced this pull request Feb 2, 2023
#12)

* Migrate resource ec_deployment_extension to terraform-plugin-framework

* Remove useless use of ec.Bool() and ec.String()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants