Skip to content

Migrate data sources to terraform-provider-framework - #3

Merged
dimuon merged 1 commit into
feature/530/migrate-to-plugin-frameworkfrom
feature/530/port-datasources
Sep 8, 2022
Merged

Migrate data sources to terraform-provider-framework#3
dimuon merged 1 commit into
feature/530/migrate-to-plugin-frameworkfrom
feature/530/port-datasources

Conversation

@pascal-hofmann

Copy link
Copy Markdown
Collaborator

Description

Related Issues

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@pascal-hofmann
pascal-hofmann force-pushed the feature/530/port-datasources branch 3 times, most recently from 79dd78c to d0d428b Compare September 7, 2022 16:46
@pascal-hofmann pascal-hofmann changed the title Feature/530/port datasources Migrate data sources to terraform-provider-framework Sep 7, 2022
@pascal-hofmann
pascal-hofmann marked this pull request as ready for review September 7, 2022 16:47
@pascal-hofmann
pascal-hofmann force-pushed the feature/530/port-datasources branch 5 times, most recently from ad3a606 to 7ad30e8 Compare September 8, 2022 04:12
@pascal-hofmann
pascal-hofmann force-pushed the feature/530/port-datasources branch from 7ad30e8 to 2194ad3 Compare September 8, 2022 04:38
@dimuon

dimuon commented Sep 8, 2022

Copy link
Copy Markdown
Owner

👍 LGTM

@dimuon

dimuon commented Sep 8, 2022

Copy link
Copy Markdown
Owner

I also run acceptance tests locally - there are 2 failures (TestAccDeploymentExtension_bundleFile and TestAccDeploymentExtension_pluginDownload) but the master branch has the same issues. I'll merge it and proceed with rebasing my changes based on the PR.

@dimuon
dimuon merged commit 1c61d77 into feature/530/migrate-to-plugin-framework Sep 8, 2022
dimuon added a commit that referenced this pull request Feb 2, 2023
Migrate data sources to terraform-provider-framework
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants