Skip to content

Migrate resource ec_deployment_traffic_filter_association to terraform-provider-framework - #5

Merged
dimuon merged 1 commit into
feature/530/migrate-to-plugin-frameworkfrom
feature/530/ec-trafficfilterassoc-only
Sep 15, 2022
Merged

Migrate resource ec_deployment_traffic_filter_association to terraform-provider-framework#5
dimuon merged 1 commit into
feature/530/migrate-to-plugin-frameworkfrom
feature/530/ec-trafficfilterassoc-only

Conversation

@pascal-hofmann

@pascal-hofmann pascal-hofmann commented Sep 14, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Migrate resource ec_deployment_traffic_filter_association to terraform-provider-framework

How Has This Been Tested?

Unit and acceptance tests were ported. Migration test added.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@pascal-hofmann
pascal-hofmann force-pushed the feature/530/ec-trafficfilterassoc-only branch from 254c194 to 27175df Compare September 14, 2022 05:05
@pascal-hofmann

pascal-hofmann commented Sep 14, 2022

Copy link
Copy Markdown
Collaborator Author

This contains all changes from your branch that are not related to the deloyment resource itself.

@dimuon Not sure why the unit tests are failing. They do work for me locally. May be it is related to some env vars. Can you check whether the tests work for you?

@dimuon

dimuon commented Sep 14, 2022

Copy link
Copy Markdown
Owner

This contains all changes from your branch that are not related to the deloyment resource itself.

@dimuon Not sure why the unit tests are failing. They do work for me locally. May be it is related to some env vars. Can you check whether the tests work for you?

Yes, sure. I'll check and let you know.

@dimuon

dimuon commented Sep 14, 2022

Copy link
Copy Markdown
Owner

This contains all changes from your branch that are not related to the deloyment resource itself.

@dimuon Not sure why the unit tests are failing. They do work for me locally. May be it is related to some env vars. Can you check whether the tests work for you?

make unit fails for me as well on the same test. Though the error message looks different

FAIL	github.com/elastic/terraform-provider-ec/ec/ecresource/trafficfilterassocresource	10.444s

@pascal-hofmann
pascal-hofmann force-pushed the feature/530/ec-trafficfilterassoc-only branch 2 times, most recently from 717effb to c814eda Compare September 14, 2022 08:20
@pascal-hofmann

pascal-hofmann commented Sep 14, 2022

Copy link
Copy Markdown
Collaborator Author 
FAIL	github.com/elastic/terraform-provider-ec/ec/ecresource/trafficfilterassocresource	10.444s

Is there more output than this?

@dimuon

dimuon commented Sep 14, 2022

Copy link
Copy Markdown
Owner 
FAIL	github.com/elastic/terraform-provider-ec/ec/ecresource/trafficfilterassocresource	10.444s

Is there more output than this?

make unit
-> Running unit tests for terraform-provider-ec...
?   	github.com/elastic/terraform-provider-ec	[no test files]
ok  	github.com/elastic/terraform-provider-ec/ec	0.705s	coverage: 30.8% of statements
ok  	github.com/elastic/terraform-provider-ec/ec/acc	0.909s	coverage: 6.7% of statements
ok  	github.com/elastic/terraform-provider-ec/ec/ecdatasource/deploymentdatasource	0.433s	coverage: 91.6% of statements
ok  	github.com/elastic/terraform-provider-ec/ec/ecdatasource/deploymentsdatasource	0.538s	coverage: 74.3% of statements
ok  	github.com/elastic/terraform-provider-ec/ec/ecdatasource/stackdatasource	0.344s	coverage: 79.6% of statements
ok  	github.com/elastic/terraform-provider-ec/ec/ecresource/deploymentresource	1.146s	coverage: 85.7% of statements
ok  	github.com/elastic/terraform-provider-ec/ec/ecresource/elasticsearchkeystoreresource	0.555s	coverage: 33.3% of statements
ok  	github.com/elastic/terraform-provider-ec/ec/ecresource/extensionresource	0.493s	coverage: 78.7% of statements
coverage: 38.7% of statements
panic: test timed out after 10s

goroutine 838 [running]:
testing.(*M).startAlarm.func1()
	/usr/local/go/src/testing/testing.go:2036 +0xb4
created by time.goFunc
	/usr/local/go/src/time/sleep.go:176 +0x48

goroutine 1 [chan receive]:
testing.(*T).Run(0xc000102d00, {0x1011c47cb, 0x1e}, 0x10172a108)
	/usr/local/go/src/testing/testing.go:1494 +0x57c
testing.runTests.func1(0x0?)
	/usr/local/go/src/testing/testing.go:1846 +0x94
testing.tRunner(0xc000102d00, 0xc000031b68)
	/usr/local/go/src/testing/testing.go:1446 +0x18c
testing.runTests(0xc0003d65a0?, {0x10206c900, 0x6, 0x6}, {0xc000682390?, 0x10029f300?, 0x102083020?})
	/usr/local/go/src/testing/testing.go:1844 +0x6c4
testing.(*M).Run(0xc0003d65a0)
	/usr/local/go/src/testing/testing.go:1726 +0x874
main.main()
	_testmain.go:117 +0x3b8

goroutine 21 [semacquire]:
sync.runtime_Semacquire(0xc000040bc8?)
	/usr/local/go/src/runtime/sema.go:62 +0x28
sync.(*WaitGroup).Wait(0xc000040bc0)
	/usr/local/go/src/sync/waitgroup.go:139 +0x88
github.com/hashicorp/terraform-exec/tfexec.(*Terraform).runTerraformCmd(0xc0003424e0, {0x101741ab0, 0xc000040158}, 0xc00021e000)
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/terraform-exec@v0.17.2/tfexec/cmd_default.go:66 +0x608
github.com/hashicorp/terraform-exec/tfexec.(*Terraform).Plan(0x101741b20?, {0x101741ab0, 0xc000040158}, {0xc00020ba98, 0x4, 0x4})
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/terraform-exec@v0.17.2/tfexec/plan.go:104 +0x70
github.com/hashicorp/terraform-plugin-sdk/v2/internal/plugintest.(*WorkingDir).CreateDestroyPlan(0xc00009c1e0, {0x101741b20, 0xc000624030})
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.21.0/internal/plugintest/working_dir.go:189 +0x1f0
github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource.testStepNewConfig.func2()
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.21.0/helper/resource/testing_new_config.go:42 +0x68
github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource.runProviderCommand({0x101741b20, 0xc000624030}, {0x101749418, 0xc000102ea0}, 0xc00020daa0, 0xc00009c1e0, 0xc00020e2a0)
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.21.0/helper/resource/plugin.go:421 +0x21b0
github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource.testStepNewConfig({_, _}, {_, _}, {0x1, 0x0, 0x0, 0xc0006826f0, 0x0, 0x0, ...}, ...)
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.21.0/helper/resource/testing_new_config.go:40 +0x264
github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource.runNewTest({0x101741b20, 0xc000624030}, {0x101749418, 0xc000102ea0}, {0x1, 0x0, 0x0, 0xc0006826f0, 0x0, 0x0, ...}, ...)
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.21.0/helper/resource/testing_new.go:247 +0x183c
github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource.Test({0x101749418, 0xc000102ea0}, {0x1, 0x0, 0x0, 0xc0006826f0, 0x0, 0x0, 0x0, 0x0, ...})
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.21.0/helper/resource/testing.go:744 +0x584
github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource.UnitTest({0x101749418, 0xc000102ea0}, {0x1, 0x0, 0x0, 0xc0006826f0, 0x0, 0x0, 0x0, 0x0, ...})
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.21.0/helper/resource/testing.go:758 +0x6c
github.com/elastic/terraform-provider-ec/ec/ecresource/trafficfilterassocresource_test.TestResourceTrafficFilterAssoc(0x0?)
	/Users/dmytroonishchenko/elastic/terraform-provider-ec/ec/ecresource/trafficfilterassocresource/resource_test.go:35 +0x464
testing.tRunner(0xc000102ea0, 0x10172a108)
	/usr/local/go/src/testing/testing.go:1446 +0x18c
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:1493 +0x560

goroutine 448 [select]:
github.com/hashicorp/terraform-exec/tfexec.writeOutput.func1()
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/terraform-exec@v0.17.2/tfexec/cmd.go:250 +0xc0
created by github.com/hashicorp/terraform-exec/tfexec.writeOutput
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/terraform-exec@v0.17.2/tfexec/cmd.go:249 +0x168

goroutine 69 [select]:
github.com/hashicorp/go-plugin.(*gRPCBrokerServer).Recv(0xc0001167e0)
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/go-plugin@v1.4.5/grpc_broker.go:121 +0xa8
github.com/hashicorp/go-plugin.(*GRPCBroker).Run(0xc0003a8820)
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/go-plugin@v1.4.5/grpc_broker.go:411 +0x54
created by github.com/hashicorp/go-plugin.(*GRPCServer).Init
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/go-plugin@v1.4.5/grpc_server.go:85 +0x758

goroutine 175 [select]:
github.com/hashicorp/go-plugin.(*gRPCBrokerServer).Recv(0xc000592510)
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/go-plugin@v1.4.5/grpc_broker.go:121 +0xa8
github.com/hashicorp/go-plugin.(*GRPCBroker).Run(0xc0003a89b0)
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/go-plugin@v1.4.5/grpc_broker.go:411 +0x54
created by github.com/hashicorp/go-plugin.(*GRPCServer).Init
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/go-plugin@v1.4.5/grpc_server.go:85 +0x758

goroutine 721 [select]:
github.com/hashicorp/terraform-exec/tfexec.writeOutput.func1()
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/terraform-exec@v0.17.2/tfexec/cmd.go:250 +0xc0
created by github.com/hashicorp/terraform-exec/tfexec.writeOutput
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/terraform-exec@v0.17.2/tfexec/cmd.go:249 +0x168

goroutine 717 [chan receive]:
github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource.runProviderCommand.func4(0x0?)
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.21.0/helper/resource/plugin.go:312 +0x38
created by github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource.runProviderCommand
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.21.0/helper/resource/plugin.go:311 +0x171c

goroutine 834 [select]:
github.com/hashicorp/go-plugin.(*gRPCBrokerServer).Recv(0xc0002fdbc0)
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/go-plugin@v1.4.5/grpc_broker.go:121 +0xa8
github.com/hashicorp/go-plugin.(*GRPCBroker).Run(0xc0005c7270)
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/go-plugin@v1.4.5/grpc_broker.go:411 +0x54
created by github.com/hashicorp/go-plugin.(*GRPCServer).Init
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/go-plugin@v1.4.5/grpc_server.go:85 +0x758

goroutine 718 [select]:
os/exec.(*Cmd).watchCtx.func1()
	/usr/local/go/src/os/exec/exec.go:648 +0xb0
created by os/exec.(*Cmd).watchCtx
	/usr/local/go/src/os/exec/exec.go:647 +0xf4

goroutine 832 [chan receive]:
github.com/hashicorp/terraform-plugin-sdk/v2/plugin.tf5serverServe.func1()
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.21.0/plugin/serve.go:155 +0x3c
created by github.com/hashicorp/terraform-plugin-sdk/v2/plugin.tf5serverServe
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.21.0/plugin/serve.go:152 +0x384

goroutine 720 [IO wait]:
internal/poll.runtime_pollWait(0x103882168, 0x72)
	/usr/local/go/src/runtime/netpoll.go:305 +0xa0
internal/poll.(*pollDesc).wait(0xc000132318, 0xc000364000?, 0x1)
	/usr/local/go/src/internal/poll/fd_poll_runtime.go:84 +0xc0
internal/poll.(*pollDesc).waitRead(...)
	/usr/local/go/src/internal/poll/fd_poll_runtime.go:89
internal/poll.(*FD).Read(0xc000132300, {0xc000364000, 0x1000, 0x1000})
	/usr/local/go/src/internal/poll/fd_unix.go:167 +0x2f0
os.(*File).read(...)
	/usr/local/go/src/os/file_posix.go:31
os.(*File).Read(0xc000010038, {0xc000364000, 0x1000, 0x1000})
	/usr/local/go/src/os/file.go:118 +0x94
bufio.(*Reader).fill(0xc00054de80)
	/usr/local/go/src/bufio/bufio.go:106 +0x21c
bufio.(*Reader).ReadSlice(0xc00054de80, 0xb0?)
	/usr/local/go/src/bufio/bufio.go:372 +0x60
bufio.(*Reader).collectFragments(0x1000?, 0x58?)
	/usr/local/go/src/bufio/bufio.go:447 +0x70
bufio.(*Reader).ReadBytes(0x101741ab0?, 0x58?)
	/usr/local/go/src/bufio/bufio.go:475 +0x38
github.com/hashicorp/terraform-exec/tfexec.writeOutput({0x101741ab0?, 0xc000040158}, {0x10173eb28?, 0xc000010038}, {0x10173b8a0, 0xc000092c80})
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/terraform-exec@v0.17.2/tfexec/cmd.go:260 +0x288
github.com/hashicorp/terraform-exec/tfexec.(*Terraform).runTerraformCmd.func2()
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/terraform-exec@v0.17.2/tfexec/cmd_default.go:61 +0xb0
created by github.com/hashicorp/terraform-exec/tfexec.(*Terraform).runTerraformCmd
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/terraform-exec@v0.17.2/tfexec/cmd_default.go:59 +0x600

goroutine 837 [IO wait]:
internal/poll.runtime_pollWait(0x1038829d8, 0x72)
	/usr/local/go/src/runtime/netpoll.go:305 +0xa0
internal/poll.(*pollDesc).wait(0xc000323e18, 0xc0004e5501?, 0x0)
	/usr/local/go/src/internal/poll/fd_poll_runtime.go:84 +0xc0
internal/poll.(*pollDesc).waitRead(...)
	/usr/local/go/src/internal/poll/fd_poll_runtime.go:89
internal/poll.(*FD).Accept(0xc000323e00)
	/usr/local/go/src/internal/poll/fd_unix.go:614 +0x2d8
net.(*netFD).accept(0xc000323e00)
	/usr/local/go/src/net/fd_unix.go:172 +0x38
net.(*UnixListener).accept(0xc0002fd8f0)
	/usr/local/go/src/net/unixsock_posix.go:166 +0x3c
net.(*UnixListener).Accept(0xc0002fd8f0)
	/usr/local/go/src/net/unixsock.go:260 +0x68
google.golang.org/grpc.(*Server).Serve(0xc0005be3c0, {0x10173ff50, 0xc00052c740})
	/Users/dmytroonishchenko/go/pkg/mod/google.golang.org/grpc@v1.49.0/server.go:796 +0x42c
github.com/hashicorp/go-plugin.(*GRPCServer).Serve(0xc0002d5320, {0x10173ff50, 0xc00052c740})
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/go-plugin@v1.4.5/grpc_server.go:138 +0x94
created by github.com/hashicorp/go-plugin.Serve
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/go-plugin@v1.4.5/server.go:465 +0x194c

goroutine 835 [IO wait]:
internal/poll.runtime_pollWait(0x103882708, 0x72)
	/usr/local/go/src/runtime/netpoll.go:305 +0xa0
internal/poll.(*pollDesc).wait(0xc000501398, 0xc0004c1000?, 0x1)
	/usr/local/go/src/internal/poll/fd_poll_runtime.go:84 +0xc0
internal/poll.(*pollDesc).waitRead(...)
	/usr/local/go/src/internal/poll/fd_poll_runtime.go:89
internal/poll.(*FD).Read(0xc000501380, {0xc0004c1000, 0x1000, 0x1000})
	/usr/local/go/src/internal/poll/fd_unix.go:167 +0x2f0
os.(*File).read(...)
	/usr/local/go/src/os/file_posix.go:31
os.(*File).Read(0xc0005ba0c0, {0xc0004c1000, 0x1000, 0x1000})
	/usr/local/go/src/os/file.go:118 +0x94
io.(*teeReader).Read(0xc00052c760, {0xc0004c1000, 0x1000, 0x1000})
	/usr/local/go/src/io/io.go:573 +0x60
bufio.(*Reader).Read(0xc0006ccf10, {0xc0000d8800, 0x400, 0x400})
	/usr/local/go/src/bufio/bufio.go:237 +0x3b0
github.com/hashicorp/go-plugin.copyChan({0x101749758, 0xc0002d5200}, 0x0?, {0x10173b320?, 0xc00052c760})
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/go-plugin@v1.4.5/grpc_stdio.go:181 +0x160
created by github.com/hashicorp/go-plugin.newGRPCStdioServer
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/go-plugin@v1.4.5/grpc_stdio.go:37 +0x154

goroutine 836 [IO wait]:
internal/poll.runtime_pollWait(0x103882d98, 0x72)
	/usr/local/go/src/runtime/netpoll.go:305 +0xa0
internal/poll.(*pollDesc).wait(0xc000501458, 0xc00002e000?, 0x1)
	/usr/local/go/src/internal/poll/fd_poll_runtime.go:84 +0xc0
internal/poll.(*pollDesc).waitRead(...)
	/usr/local/go/src/internal/poll/fd_poll_runtime.go:89
internal/poll.(*FD).Read(0xc000501440, {0xc00002e000, 0x1000, 0x1000})
	/usr/local/go/src/internal/poll/fd_unix.go:167 +0x2f0
os.(*File).read(...)
	/usr/local/go/src/os/file_posix.go:31
os.(*File).Read(0xc0005ba0d0, {0xc00002e000, 0x1000, 0x1000})
	/usr/local/go/src/os/file.go:118 +0x94
io.(*teeReader).Read(0xc00052c780, {0xc00002e000, 0x1000, 0x1000})
	/usr/local/go/src/io/io.go:573 +0x60
bufio.(*Reader).Read(0xc0006c1f10, {0xc000212000, 0x400, 0x400})
	/usr/local/go/src/bufio/bufio.go:237 +0x3b0
github.com/hashicorp/go-plugin.copyChan({0x101749758, 0xc0002d5200}, 0x0?, {0x10173b320?, 0xc00052c780})
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/go-plugin@v1.4.5/grpc_stdio.go:181 +0x160
created by github.com/hashicorp/go-plugin.newGRPCStdioServer
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/go-plugin@v1.4.5/grpc_stdio.go:38 +0x23c

goroutine 831 [select]:
github.com/hashicorp/go-plugin.Serve(0xc0005011a0)
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/go-plugin@v1.4.5/server.go:471 +0x1a34
github.com/hashicorp/terraform-plugin-go/tfprotov5/tf5server.Serve({0xc0005c2240, 0x22}, 0xc0005a2b28, {0xc00003cc80, 0x3, 0x4})
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/terraform-plugin-go@v0.14.0/tfprotov5/tf5server/server.go:312 +0xed8
github.com/hashicorp/terraform-plugin-sdk/v2/plugin.tf5serverServe(0xc000501080)
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.21.0/plugin/serve.go:178 +0x7b8
github.com/hashicorp/terraform-plugin-sdk/v2/plugin.Serve(0xc000501080)
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.21.0/plugin/serve.go:120 +0x240
created by github.com/hashicorp/terraform-plugin-sdk/v2/plugin.DebugServe
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.21.0/plugin/debug.go:44 +0x224

goroutine 719 [IO wait]:
internal/poll.runtime_pollWait(0x103882ca8, 0x72)
	/usr/local/go/src/runtime/netpoll.go:305 +0xa0
internal/poll.(*pollDesc).wait(0xc000132258, 0xc00002f000?, 0x1)
	/usr/local/go/src/internal/poll/fd_poll_runtime.go:84 +0xc0
internal/poll.(*pollDesc).waitRead(...)
	/usr/local/go/src/internal/poll/fd_poll_runtime.go:89
internal/poll.(*FD).Read(0xc000132240, {0xc00002f000, 0x1000, 0x1000})
	/usr/local/go/src/internal/poll/fd_unix.go:167 +0x2f0
os.(*File).read(...)
	/usr/local/go/src/os/file_posix.go:31
os.(*File).Read(0xc000010028, {0xc00002f000, 0x1000, 0x1000})
	/usr/local/go/src/os/file.go:118 +0x94
bufio.(*Reader).fill(0xc00054ce80)
	/usr/local/go/src/bufio/bufio.go:106 +0x21c
bufio.(*Reader).ReadSlice(0xc00054ce80, 0x0?)
	/usr/local/go/src/bufio/bufio.go:372 +0x60
bufio.(*Reader).collectFragments(0x1000?, 0x58?)
	/usr/local/go/src/bufio/bufio.go:447 +0x70
bufio.(*Reader).ReadBytes(0x101741ab0?, 0x58?)
	/usr/local/go/src/bufio/bufio.go:475 +0x38
github.com/hashicorp/terraform-exec/tfexec.writeOutput({0x101741ab0?, 0xc000040158}, {0x10173eb28?, 0xc000010028}, {0x10173c940, 0x1020b3100})
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/terraform-exec@v0.17.2/tfexec/cmd.go:260 +0x288
github.com/hashicorp/terraform-exec/tfexec.(*Terraform).runTerraformCmd.func1()
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/terraform-exec@v0.17.2/tfexec/cmd_default.go:55 +0xb0
created by github.com/hashicorp/terraform-exec/tfexec.(*Terraform).runTerraformCmd
	/Users/dmytroonishchenko/go/pkg/mod/github.com/hashicorp/terraform-exec@v0.17.2/tfexec/cmd_default.go:53 +0x47c
FAIL	github.com/elastic/terraform-provider-ec/ec/ecresource/trafficfilterassocresource	10.444s
ok  	github.com/elastic/terraform-provider-ec/ec/ecresource/trafficfilterresource	0.387s	coverage: 76.8% of statements
?   	github.com/elastic/terraform-provider-ec/ec/internal	[no test files]
ok  	github.com/elastic/terraform-provider-ec/ec/internal/flatteners	0.239s	coverage: 41.7% of statements
?   	github.com/elastic/terraform-provider-ec/ec/internal/planmodifier	[no test files]
ok  	github.com/elastic/terraform-provider-ec/ec/internal/util	0.271s	coverage: 55.1% of statements
?   	github.com/elastic/terraform-provider-ec/ec/internal/validators	[no test files]
FAIL
make: *** [unit] Error 1

@pascal-hofmann
pascal-hofmann force-pushed the feature/530/ec-trafficfilterassoc-only branch 5 times, most recently from a5da6a0 to 2834bcf Compare September 14, 2022 12:46
@pascal-hofmann pascal-hofmann mentioned this pull request Sep 14, 2022
Closed
10 tasks
@pascal-hofmann
pascal-hofmann marked this pull request as ready for review September 14, 2022 12:52
@pascal-hofmann

pascal-hofmann commented Sep 14, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Tests are working on GitHub now. This was the root cause:
https://github.com/dimuon/terraform-provider-ec/pull/5/files#diff-678682767f2477de3e3c546746f8568b9a1942b2c647d32331d7e774b8ff8d9fR25

dimuon
dimuon reviewed Sep 14, 2022
View reviewed changes
Comment thread go.mod
dimuon
dimuon reviewed Sep 14, 2022
View reviewed changes
Comment thread ec/acc/deployment_traffic_filter_association_test.go
dimuon
dimuon reviewed Sep 14, 2022
View reviewed changes
Comment thread ec/ecresource/trafficfilterassocresource/create.go
dimuon
dimuon reviewed Sep 14, 2022
View reviewed changes
Comment thread ec/ecresource/trafficfilterassocresource/create.go
dimuon
dimuon reviewed Sep 14, 2022
View reviewed changes
Comment thread ec/ecresource/trafficfilterassocresource/resource_test.go
dimuon
dimuon reviewed Sep 14, 2022
View reviewed changes
Comment thread ec/ecresource/trafficfilterassocresource/delete.go Outdated
@pascal-hofmann
pascal-hofmann force-pushed the feature/530/ec-trafficfilterassoc-only branch from 2834bcf to a5de6e9 Compare September 15, 2022 06:19
@dimuon

dimuon commented Sep 15, 2022

Copy link
Copy Markdown
Owner

LGTM

@dimuon
dimuon merged commit b7c8e23 into feature/530/migrate-to-plugin-framework Sep 15, 2022
@pascal-hofmann
pascal-hofmann deleted the feature/530/ec-trafficfilterassoc-only branch September 15, 2022 12:26
dimuon added a commit that referenced this pull request Feb 2, 2023
@dimuon
Merge pull request #5 from dimuon/feature/530/ec-trafficfilterassoc-only
d90e0d1 
Migrate resource ec_deployment_traffic_filter_association to terraform-provider-framework
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dimuon dimuon dimuon left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pascal-hofmann @dimuon