New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(trimScale): check for zero value in countTrailingZeros #448
fix(trimScale): check for zero value in countTrailingZeros #448
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/dinerojs/dinerojs/CNkH93MJzLqQHnNKEEdUPtqGxWYa |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e02ec1b:
|
Thank you @reckter, I haven't had the time to look into your PR, I will do it this week end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @reckter, good catch! Let me know if you need further help.
@sarahdayan I left the comments "unresolved", as I wasn't sure how you handle these on PR's here. I've should've fixed all of them, so feel free to resolve them :) |
Hey, is there anything I can do to help get this merged? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're good to go! Thanks @reckter I'll deploy this soon.
@sarahdayan or any other maintainer, can you please trigger the release pipeline? |
trimSccale
, when called with a0
as theamount
, kept in a endless loop.Cause:
countTrailingZeros
was stuck, as there never was any non-zero value to brake the loop.I am unsure wether this is the cleanest solution, but it at least fixes the problem.
Also added a quick test for regression.