Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use crypto/rand for XSRF token generation #24

Merged
merged 1 commit into from Jun 11, 2016

Conversation

bentranter
Copy link
Contributor

Issue: #20

Uses crypto/rand instead of math/rand for XSRF token generation, as @elithrar suggested. In that issue it was also suggested that we either use gorilla/csrf or repurpose it for Golf, so this PR may not close the issue.

Issue: dinever#20

Uses crypto/rand instead of math/rand for XSRF token generation, as
@elithrar suggested. In that issue it was also suggested that we either
use gorilla/csrf or repurpose it for Golf, so this PR may not close the
issue.
@elithrar
Copy link

elithrar commented Jun 4, 2016

LGTM. This is probably the more important piece (using another lib can come later).

@dinever
Copy link
Owner

dinever commented Jun 11, 2016

Thanks for the contribution! This looks great to me!

@dinever dinever merged commit 3776f33 into dinever:master Jun 11, 2016
@bentranter bentranter deleted the use-crypto-rand-for-xsrf branch June 11, 2016 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants