4139: Minor changes to opensearch cache #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
|
reviewed and approved |
holt83
reviewed
Mar 7, 2019
| @@ -554,13 +565,18 @@ function _opensearch_predict_cache(array $collections, TingClientRequest $reques | |||
| $object_request->setProfile($profile); | |||
| } | |||
|
|
|||
| // Build both requests for local id and PID. | |||
| $object_id_request = clone $object_request; | |||
| $object_id_request->setObjectId($object->id); | |||
| $local_id_request = clone $object_request; | |||
| $local_id_request->setLocalId($object->localId); | |||
There was a problem hiding this comment.
@cableman I know this is not from this PR, but isn't this a bit dangerous? The localId is not guaranteed to unique over all owners, so we are really not sure this object is the correct cache response for this localID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://platform.dandigbib.org/issues/4139
Description
In working with ereolen.dk we had issues with ting object that contained content from other objects and cache misses after the first view (which should not happen as the first view populated the cache).
Screenshot of the result
No screenshot
Checklist
Additional comments or questions
Linked to ding2/ting-client#29