Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3585: Pipe Adgangsplatformen callbacks through Varnish #1661

Merged
merged 1 commit into from Jul 7, 2020

Conversation

kasperg
Copy link
Member

@kasperg kasperg commented Jul 7, 2020

Link to issue

https://platform.dandigbib.org/issues/3585#note-84

Description

This will prevent any Varnish processing of the request including
stripping of any cookies which contain information about the
consent id of the user.

If the cookie containing the consent id is stripped then it cannot
be migrated from an anonymous user to the authenticated user during
login.

Checklist

  • My complies with our coding guidelines.
  • My code passes our static analysis suite. If not then I have added a comment explaining why this change should be exempt from the code standards and process.
  • My code passes our continuous integration process. If not then I have added a comment explaining why this change should be exempt from the code standards and process.

This will prevent any Varnish processing of the request including
stripping of any cookies which contain information about the
consent id of the user.

If the cookie containing the consent id is stripped then it cannot
be migrated from an anonymous user to the authenticated user during
login.
@kasperg kasperg merged commit 73c41ed into ding2:master Jul 7, 2020
@kasperg kasperg deleted the 3585-adgangsplatformen-pipe branch July 7, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants