From 186fde08df78bc9846e3b3e870287718a0083e15 Mon Sep 17 00:00:00 2001 From: Yabo Hu Date: Wed, 4 Mar 2020 16:19:28 +0800 Subject: [PATCH 1/4] add SupportedAggregationTypes and Dimentions to PSMetricDefinition --- src/Monitor/Monitor/OutputClasses/PSMetricDefinition.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Monitor/Monitor/OutputClasses/PSMetricDefinition.cs b/src/Monitor/Monitor/OutputClasses/PSMetricDefinition.cs index b155df423e02..9ae16dc5dfba 100644 --- a/src/Monitor/Monitor/OutputClasses/PSMetricDefinition.cs +++ b/src/Monitor/Monitor/OutputClasses/PSMetricDefinition.cs @@ -26,7 +26,7 @@ public class PSMetricDefinition : MetricDefinition /// /// The MetricDefinition public PSMetricDefinition(MetricDefinition metricDefinition) - : base(name: new PSLocalizableString(metricDefinition.Name), metricAvailabilities: new PSMetricAvailabilityCollection(metricDefinition.MetricAvailabilities), primaryAggregationType: metricDefinition.PrimaryAggregationType, resourceId: metricDefinition.ResourceId, unit: metricDefinition.Unit, id: metricDefinition.Id) + : base(name: new PSLocalizableString(metricDefinition.Name), metricAvailabilities: new PSMetricAvailabilityCollection(metricDefinition.MetricAvailabilities), primaryAggregationType: metricDefinition.PrimaryAggregationType, resourceId: metricDefinition.ResourceId, unit: metricDefinition.Unit, id: metricDefinition.Id, dimensions: metricDefinition.Dimensions, supportedAggregationTypes: metricDefinition.SupportedAggregationTypes) { } } From 189002bf1e4e49dc8998b3cfa22e75d2afcfdaaf Mon Sep 17 00:00:00 2001 From: Yabo Hu Date: Wed, 4 Mar 2020 17:24:31 +0800 Subject: [PATCH 2/4] add entry in changelog.md --- src/Monitor/Monitor/ChangeLog.md | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Monitor/Monitor/ChangeLog.md b/src/Monitor/Monitor/ChangeLog.md index c21b5bb43077..c864f9e13da4 100644 --- a/src/Monitor/Monitor/ChangeLog.md +++ b/src/Monitor/Monitor/ChangeLog.md @@ -21,6 +21,7 @@ * Fixed description of the Get-AzLog cmdlet. * A new parameter called ActionGroupId was added to `New-AzMetricAlertRuleV2` command. - The user can provide either ActionGroupId(string) or ActionGorup(ActivityLogAlertActionGroup). +*Fix output value for Get-AzMetricDefinition ## Version 1.5.0 * Update references in .psd1 to use relative path From a12d907808c62fe87a84f2eb0fb735828e47807e Mon Sep 17 00:00:00 2001 From: Yabo Hu Date: Wed, 4 Mar 2020 17:26:26 +0800 Subject: [PATCH 3/4] fix format in changelog.md --- src/Monitor/Monitor/ChangeLog.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Monitor/Monitor/ChangeLog.md b/src/Monitor/Monitor/ChangeLog.md index c864f9e13da4..89518c7d9a9a 100644 --- a/src/Monitor/Monitor/ChangeLog.md +++ b/src/Monitor/Monitor/ChangeLog.md @@ -21,7 +21,7 @@ * Fixed description of the Get-AzLog cmdlet. * A new parameter called ActionGroupId was added to `New-AzMetricAlertRuleV2` command. - The user can provide either ActionGroupId(string) or ActionGorup(ActivityLogAlertActionGroup). -*Fix output value for Get-AzMetricDefinition +* Fix output value for Get-AzMetricDefinition ## Version 1.5.0 * Update references in .psd1 to use relative path From 30302ac837a2728eba909dccce45aee11560fec4 Mon Sep 17 00:00:00 2001 From: Dingmeng Xue <56333063+dingmeng-xue@users.noreply.github.com> Date: Wed, 4 Mar 2020 20:37:00 +0800 Subject: [PATCH 4/4] Update ChangeLog.md --- src/Monitor/Monitor/ChangeLog.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Monitor/Monitor/ChangeLog.md b/src/Monitor/Monitor/ChangeLog.md index 89518c7d9a9a..2c27c1e447d2 100644 --- a/src/Monitor/Monitor/ChangeLog.md +++ b/src/Monitor/Monitor/ChangeLog.md @@ -21,7 +21,7 @@ * Fixed description of the Get-AzLog cmdlet. * A new parameter called ActionGroupId was added to `New-AzMetricAlertRuleV2` command. - The user can provide either ActionGroupId(string) or ActionGorup(ActivityLogAlertActionGroup). -* Fix output value for Get-AzMetricDefinition +* Fixed output value for Get-AzMetricDefinition ## Version 1.5.0 * Update references in .psd1 to use relative path