Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 8 Support? #1745

Closed
khanhvu14 opened this issue Sep 9, 2020 · 10 comments · Fixed by #1748
Closed

Laravel 8 Support? #1745

khanhvu14 opened this issue Sep 9, 2020 · 10 comments · Fixed by #1748

Comments

@khanhvu14
Copy link

Laravel 8 has just realeased, can add new tag support it?

@Vivian-A
Copy link

Vivian-A commented Sep 9, 2020

I can't get it to install on Laravel 8 unfortunately. Composer spews out a ton of errors, most of which say "Don't install laravel/framework v8.0.0" or "Remove laravel/framework v8.0.0".

@specialtactics
Copy link
Member

Would you guys mind pulling in this commit locally and testing with your project and Laravel 8?

I will do the same testing, but I want as many people as possible to test to find issues before we push support live.

660fd77

@bbashy
Copy link

bbashy commented Sep 15, 2020

@specialtactics Just tested with newly upgraded project using "dingo/api": "dev-master#660fd77164fb4c61981f94d78e5cea67212a16ce", and it works fine by the looks of it. Got a few routes with a custom guard (sanctum) and no errors.

@specialtactics
Copy link
Member

Thanks for your help @bbashy

Just in case people might be looking over this, I will set a deadline of 21st of September of when I will tag it, assuming no errors are uncovered from testing.

@gazben
Copy link
Contributor

gazben commented Sep 22, 2020

@specialtactics Did you find any errors? Can you tag the next version?

@anardil
Copy link

anardil commented Sep 22, 2020

@specialtactics any news about the support of Laravel 8?

@specialtactics
Copy link
Member

Tagged here guys !
https://github.com/dingo/api/releases/tag/v3.0.2-rc1

@gtjamesa
Copy link
Contributor

All API tests are passing on my application with custom guards 👍 Thanks for tagging @specialtactics

@khanhvu14
Copy link
Author

Thanks @specialtactics I tested about 2 weeks with small and medium projects. Everything seems work well.

@specialtactics
Copy link
Member

If anyone ends up having any problems relating to laravel 8, feel free to report as a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants