API crashes (internaly) when requesting non-existing API version

[Andreyco]

When requesting endpoint on API version that does not exists, app crashes. It would be good to throw an exception instead.

API version is specified in request Accept header and is set to (application/vnd.myvendorname.v2+json)

Exception thrown and stack trace

[2014-12-07 15:08:58] production.ERROR: exception 'Symfony\Component\Debug\Exception\FatalErrorException' with message 'Call to a member function match() on a non-object' in /Applications/MAMP/htdocs/rkapi/vendor/dingo/api/src/Routing/Router.php:333
Stack trace:
#0 [internal function]: Illuminate\Exception\Handler->handleShutdown()
#1 {main} [] []

I will dig into this later and try to fix it. If you happen to resolve this before me, drop a line here please.
Have a nice day! :)

[jasonlewis]

You're not using API::version()? I'll take a look when I can.

[Andreyco]

No, I set version in routes file.

The file looks like this

Route::api(['version' => 'v1'], function () {
    Route::get('me', function() {
        return 'v1 me';
    });
});

Route::api(['version' => 'v2'], function () {
    Route::get('me', function() {
        return 'v2 me';
    });
});

If I do request with Accept: application/vnd.vendor.v1+json or Accept: application/vnd.vendor.v2+json the example works as intended.

By specifying version to v3 I get the exception: Call to a member function match() on a non-object caused by this line.

Since route collection is not found by getByVersion, there is no object to execute ->match($request) against. Seems like there is no checking whether the specified API version exists, thus the error.
I think, proper way would be to fire Exception which would inform API consumer that unsupported API version is requested.

What do you think? Any suggestions on Exception naming?

[jasonlewis]

Should probably be a BadRequestHttpException I think.

On Mon, 8 Dec 2014 11:10 Andrej Badin notifications@github.com wrote:

No, I set version in routes file.

The file looks like this

Route::api(['version' => 'v1'], function () { Route::get('me', function() { return 'v1 me'; });});Route::api(['version' => 'v2'], function () { Route::get('me', function() { return 'v2 me'; });});

If I do request with Accept: application/vnd.vendor.v1+json or Accept:
application/vnd.vendor.v2+json the example works as intended.

By specifying version to v3 I get the exception: Call to a member
function match() on a non-object caused by this

api/src/Routing/Router.php

Line 344 in 48ae271

$route = $this->api->getByVersion($this->currentVersion)->match($request);

line.

Since route collection is not found by getByVersion, there is no object
to execute ->match($request) against. Seems like there is no checking
whether the specified API version exists, thus the error.
I think, proper way would be to fire Exception which would inform API
consumer that unsupported API version is requested.

What do you think? Any suggestions on Exception naming?

—
Reply to this email directly or view it on GitHub
#281 (comment).

[jasonlewis]

Which is the Symfony exception.

On Mon, 8 Dec 2014 11:12 Jason Lewis jason.lewis1991@gmail.com wrote:

Should probably be a BadRequestHttpException I think.

On Mon, 8 Dec 2014 11:10 Andrej Badin notifications@github.com wrote:

No, I set version in routes file.

The file looks like this

Route::api(['version' => 'v1'], function () { Route::get('me', function() { return 'v1 me'; });});Route::api(['version' => 'v2'], function () { Route::get('me', function() { return 'v2 me'; });});

If I do request with Accept: application/vnd.vendor.v1+json or Accept:
application/vnd.vendor.v2+json the example works as intended.

By specifying version to v3 I get the exception: Call to a member
function match() on a non-object caused by this

api/src/Routing/Router.php

Line 344 in 48ae271

$route = $this->api->getByVersion($this->currentVersion)->match($request);

line.

Since route collection is not found by getByVersion, there is no object
to execute ->match($request) against. Seems like there is no checking
whether the specified API version exists, thus the error.
I think, proper way would be to fire Exception which would inform API
consumer that unsupported API version is requested.

What do you think? Any suggestions on Exception naming?

—
Reply to this email directly or view it on GitHub
#281 (comment).

[Andreyco]

Yeah, I agree.