Throw an Exception for invalid API version #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When requesting invalid API version, throw an exception which gets transformed into JSON response.
Contributor
|
Hm, I think I'd prefer the exception to be thrown from within the router and not the collection. Also be mindful of the recent docblock changes. Seems your commit has re-adjusted. |
Contributor
Author
|
I corrected docblocks, editor package messed them up, sorry. Also I didn't want to nest another |
Contributor
|
Still seems to be several docblock changes in the |
Contributor
Author
|
Ouch, sorry. I reverted the GroupCollection completely! |
jasonlewis
added a commit
that referenced
this pull request
Dec 10, 2014
Throw an Exception for invalid API version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When requesting invalid API version, throw an exception which gets transformed into JSON response.
Fixes #281