Adds ting_details theming functions. #35

Merged
merged 1 commit into from May 22, 2012

Conversation

Projects
None yet
2 participants
@xendk
Contributor

xendk commented Apr 20, 2012

The new ting_details theming fails with the alternator mobile theme, as it uses div and span as element type for theme_item_list, which is a dynamo extension. As LI elements aren't allowed in divs/spans, this creates invalid markup.

This pull request defines new ting_details and ting_details_group theming functions, which per default generates regular ul lists.

There's another pull request for dynamo forthcoming, which themes ting_details and ting_details_group like the current ting, so that no styling needs to be updated if both pull requests are implemented.

Adds ting_details theming functions.
Makes it easier to override the theming.
@xendk

This comment has been minimized.

Show comment Hide comment
@xendk

xendk Apr 20, 2012

Contributor

Dynamo pull here: dingproject/dynamo#12

Contributor

xendk commented Apr 20, 2012

Dynamo pull here: dingproject/dynamo#12

@cableman

This comment has been minimized.

Show comment Hide comment
@cableman

cableman Apr 23, 2012

Member

Nice fixes, but I have to request a lighthouse ticket... so the fix can be scheduled into a release.

Member

cableman commented Apr 23, 2012

Nice fixes, but I have to request a lighthouse ticket... so the fix can be scheduled into a release.

@cableman

This comment has been minimized.

Show comment Hide comment
@cableman

cableman May 22, 2012

Member

Reviewed and accepted

Member

cableman commented May 22, 2012

Reviewed and accepted

cableman added a commit that referenced this pull request May 22, 2012

Merge pull request #35 from helsbib/ting_details_theming
Adds ting_details theming functions.

@cableman cableman merged commit cce7bbb into dingproject:master May 22, 2012

kasperg added a commit to reload/ting that referenced this pull request Oct 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment