Crash because of uninitialized critical session (When using SASL) #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -42,15 +42,18 @@ | |||
| static int sasl_use_count = 0; | |||
|
|
|||
| #ifdef LIBETPAN_REENTRANT | |||
|
|
|||
| void mailsasl_init_lock(){ | |||
There was a problem hiding this comment.
Why did you move it out of #if defined WIN32?
This function is only needed on win32.
|
I wanted to put mailsasl_init_lock() in line with other lock init functions: mmapstring_init_lock() and mailstream_ssl_init_lock(). Both of them are need only on windows, but declared on all platforms |
|
Ok. To match other platforms, could you move the header declaration in a mailsasl_private.h file? |
|
Done |
|
Great! Thanks! |
|
Wait for continuous integration to give me a go :) |
dinhvh
added a commit
that referenced
this pull request
Apr 4, 2014
Crash because of uninitialized critical session (When using SASL)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.