Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reply/Quote messages #625

Closed
Perflyst opened this issue Oct 4, 2019 · 10 comments
Closed

Reply/Quote messages #625

Perflyst opened this issue Oct 4, 2019 · 10 comments
Labels
feature request Request to add a new feature to Dino

Comments

@Perflyst
Copy link

Perflyst commented Oct 4, 2019

Please add an option to quote / reply to a message

@roobre
Copy link
Contributor

roobre commented Oct 8, 2019

I'm interested in this as well. I'd like to discuss it a bit tho. What should be the UI/UX for replying/quoting? It would need to stick to the currrent design, so contextual menus are out of the question. Some ideas that come to my mind:

  • A small reply button appearing at the end of a message onHover
    • ✔️ Non-intrusive
    • ❌ Uses hover, so needs mouse interaction (neither keyboard nor touchscreen friendly)
      • ❔ Perhaps GTK can handle this for us, and make the onHover actions proc onTap for touchscreens?
  • A small reply button appearing at the end of a message (always shown)
    • ✔️ Easy interaction
    • ❌ Clutters the UI
  • Single/double click/tap on message
    • ✔️ Works on touch
    • ❌ Not intuitive, conflicts with selecting text
  • Just right click/long tap
    • ✔️ Touch/mouse friendly
    • ❌ Maybe harder to implement?
    • ❔ Needs extra care for not conflicting with the contextual menu when text is selected

Any thoughts? Once the UI/UX is clear it should be fairly easy to implement, as it's just appending the selected message text to the input box.

@fauno
Copy link

fauno commented Nov 1, 2019

telegram and conversations use contextual menus for replying, single and long taps respectively. tg desktop shows a 'reply' link on hover (not sure how to do it with keyboard)

also, conversations adds a '> ' quote and processes it as a markdown blockquote, so maybe you could follow the same convention? it makes me think xmpp doesn't have support for threading messages

@roobre
Copy link
Contributor

roobre commented Nov 1, 2019

AFAIK there is no threading support (at least not widespread) for XMPP.

Regarding styling, the markdown-ish syntax you mean is XEP-0393: Message Styling, for which there is WIP support on Dino.

@fiaxh fiaxh added the feature request Request to add a new feature to Dino label Dec 31, 2019
@mimi89999
Copy link
Collaborator

I think that a right click on desktop and long click on mobile and option from context menu would be the best UI. There could also be a keyboard shortcut like ctrl+up/down to scroll through the messages one wants to reply to.

@singpolyma
Copy link
Contributor

AFAIK there is no threading support (at least not widespread) for XMPP.

Threading support is actually baked right into the base standard, and is supported in a basic way by many clients (such as Gajim) -- what's largely missing from the ecosystem is clients with good UI for it...

@muppeth
Copy link

muppeth commented Nov 23, 2020

I think being able to just right click (or long press in case of mobile) and select quote like on conversations would be already a good feature. Currently its hard to quote someone easily (you need to manually copy the text and add formatting for quote).

@selurvedu
Copy link
Contributor

For the record, I added a quote button in a local branch, which greatly improved my UX. Unfortunately, it required a few hacks in the code that nobody would merge, so there is no point in publishing it until I figure out how to implement it properly.

@Quix0r
Copy link

Quix0r commented Mar 3, 2021

Much wanted feature! So far I have to add a > + copy-paste the message when I want to quote it. This would shortcut it. And what about existing messages in the input box?

@MarcoPolo-PasTonMolo
Copy link

As no such button is welcomed for the quote feature by the devs, if somebody is interested an idea would be to implement autocompletion for previous messages when the start of the input starts with '>'. profanity-im/profanity#1651 relevant pull request for profanity

@fiaxh
Copy link
Member

fiaxh commented Jan 6, 2023

Done in dc52e75.


Screenshot from 2023-01-06 14-35-14

@fiaxh fiaxh closed this as completed Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request to add a new feature to Dino
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants