Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password field shouldn't indicate password length #797

Open
guilieb opened this issue Apr 6, 2020 · 2 comments
Open

Password field shouldn't indicate password length #797

guilieb opened this issue Apr 6, 2020 · 2 comments
Labels
✨ UI Affecting or caused by the user interface of Dino

Comments

@guilieb
Copy link

guilieb commented Apr 6, 2020

Hi,

When connecting using an account which is protected by a very long password, the window with is too large. As well, for security reasons, this password field should not give any indication on the password length.

Capture d’écran du 2020-04-06 11-47-39

Installed Packages
Name         : dino
Version      : 0.1.0
Release      : 1.fc31
Architecture : x86_64
Size         : 3.8 M
Source       : dino-0.1.0-1.fc31.src.rpm
Repository   : @System
From repo    : updates
Summary      : Modern XMPP ("Jabber") Chat Client using GTK+/Vala
URL          : https://github.com/dino/dino
License      : GPLv3
Description  : A modern XMPP ("Jabber") chat client using GTK+/Vala.
@mar-v-in mar-v-in added glitch Artifacts causing degraded user experience ✨ UI Affecting or caused by the user interface of Dino good first issue Relatively easy to fix, makes a good start for first time contributors labels Apr 10, 2020
@Echolon Echolon mentioned this issue Apr 15, 2020
Open
sshikaree added a commit to sshikaree/dino that referenced this issue Mar 8, 2021
@sshikaree
Fix accounts panel width dino#797
fe82a05
sshikaree added a commit to sshikaree/dino that referenced this issue Mar 9, 2021
@sshikaree
Fix accounts panel width dino#797
83c4233
sshikaree added a commit to sshikaree/dino that referenced this issue Mar 9, 2021
@sshikaree
Fix accounts panel width (dino#797)
053f8f8
@fiaxh fiaxh closed this as completed in 45c0ac4 Mar 24, 2021
@fiaxh
Copy link
Member

fiaxh commented Mar 24, 2021

#1017 fixed the window width problem, however I'll keep this issue opened for the second point that you mentioned: the password length indication.

@fiaxh fiaxh reopened this Mar 24, 2021
@fiaxh fiaxh changed the title Accounts panel width is too big if password is long Password field shouldn't indicate password length Mar 24, 2021
@fiaxh fiaxh removed good first issue Relatively easy to fix, makes a good start for first time contributors glitch Artifacts causing degraded user experience labels Mar 24, 2021
LAGonauta pushed a commit to LAGonauta/dino that referenced this issue Mar 26, 2021
@sshikaree @LAGonauta
Fix accounts panel width (dino#1017)
6c2e1ec 
fixes dino#797
LAGonauta pushed a commit to LAGonauta/dino that referenced this issue Mar 27, 2021
@sshikaree @LAGonauta
Fix accounts panel width (dino#1017)
11d7180 
fixes dino#797
fiaxh pushed a commit that referenced this issue Jun 3, 2021
@sshikaree @fiaxh
Fix accounts panel width (#1017)
4bdffa9 
fixes #797
fiaxh pushed a commit that referenced this issue Jun 7, 2021
@sshikaree @fiaxh
Fix accounts panel width (#1017)
43ed66f 
fixes #797
eerielili added a commit to eerielili/dino that referenced this issue Aug 15, 2023
@eerielili
Obfuscate password length in account dialog (fixes dino#797)
75d29bd
@eerielili
Copy link
Contributor

eerielili commented Aug 15, 2023 •
edited

@guilieb @fiaxh I pushed something that fixes it.
Tested it on my side and it works well. The password length is only ever revealed when you update your password by typing/copy pasting. Once you reopen the dialog the obsfucation is back again.

@eerielili eerielili mentioned this issue Sep 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ UI Affecting or caused by the user interface of Dino
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mar-v-in @fiaxh @guilieb @eerielili