tls handshake: when peer closes the connection, server also closes it #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is fine, since the tls_mirage code isn't consistent in |
dinosaure
force-pushed
the
close-on-handshake-fail
branch
from
9dd6344 to
cd92ae4
Compare
|
Thanks, do you confirm that it solves the memory issue on |
|
Let's say that it's ok 👍. |
|
Yes it fixes the issue. But looking at the metrics, there's still a connection leak that is not solved |
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Oct 19, 2022
CHANGES: - Fix a file-descriptor leak when we fail on the TLS handshake (dinosaure/paf-le-chien#72, @TheLortex, @dinosaure, @hannesm) - Add `reneg` function into `Paf_mirage.Make.TLS` (dinosaure/paf-le-chien#73, @dinosaure)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.