New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove S(foo) syntax from library & tests #115

Merged
merged 14 commits into from Jan 13, 2016

Conversation

1 participant
@skirpichev
Copy link
Collaborator

skirpichev commented Aug 2, 2015

  • document why
  • Integer(foo)/Integer(bar) -> Rational(foo, bar)
  • rebase

@skirpichev skirpichev force-pushed the replace-S branch from ba287a9 to 0cdc0e3 Aug 3, 2015

@skirpichev skirpichev force-pushed the replace-S branch from b801379 to 63529e5 Aug 11, 2015

@skirpichev skirpichev force-pushed the replace-S branch from 4c94355 to 473e59f Aug 27, 2015

@skirpichev skirpichev force-pushed the replace-S branch 3 times, most recently from 3ee38d7 to 25fe6a8 Dec 14, 2015

@skirpichev skirpichev force-pushed the replace-S branch 2 times, most recently from 028a2bb to 427b6bb Dec 22, 2015

@skirpichev skirpichev force-pushed the replace-S branch 4 times, most recently from d12392b to 8655ac8 Jan 3, 2016

skirpichev added some commits Aug 2, 2015

Don't use S(foo) in the codebase
This syntax is very cubersome for using in the library
core.  Explicit calls to Integer/Rational/Float - should
be better here.  Also S(foo) is useless for interactive
work (we use ast transformations in the IPython to get Integer
for int literals).

@skirpichev skirpichev force-pushed the replace-S branch from 8655ac8 to e833f94 Jan 11, 2016

@skirpichev skirpichev force-pushed the replace-S branch from e833f94 to 3373a9f Jan 11, 2016

skirpichev added a commit that referenced this pull request Jan 13, 2016

Merge pull request #115 from skirpichev/replace-S
Remove S(foo) syntax from library & tests

@skirpichev skirpichev merged commit 855553d into master Jan 13, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 91.907%
Details

@skirpichev skirpichev deleted the replace-S branch Jan 13, 2016

@skirpichev skirpichev modified the milestone: 0.8.0 Sep 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment