New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial fix for sympy/sympy#4064, test doit #219

Merged
merged 4 commits into from Feb 6, 2016

Conversation

3 participants
@skirpichev
Copy link
Collaborator

skirpichev commented Feb 5, 2016

Thanks @ppuedom for patch.

ppuedom and others added some commits Feb 4, 2014

Issue 4064: add **hints to sign.doit()
sign.doit() was missing **hints parameter, causing an exception at
integrate.
I added test_issue_4064() in test_failing_integrals.py.
I @xfail it because even if the exception is no longer raised, the
integral is still not evaluated.
Add test to check if doit() interface is uniform
This also fix some inconsistent doit definitions,
Density.doit fix is a hack, I should figure out
how to do this better.

Thanks to @smichr for idea.

@skirpichev skirpichev force-pushed the part-fix-4064 branch from dc58db0 to b3cdd0a Feb 6, 2016

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 6, 2016

Current coverage is 88.99%

Merging #219 into master will increase coverage by +52.37% as of d70cb76

Powered by Codecov. Updated on successful CI builds.

skirpichev added a commit that referenced this pull request Feb 6, 2016

@skirpichev skirpichev merged commit 17fe46d into master Feb 6, 2016

3 checks passed

codecov/patch 100.00% of diff hit (target 90.00%)
Details
codecov/project 89.01% (+0.02%) compared to d70cb76 at 88.99%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skirpichev skirpichev deleted the part-fix-4064 branch Feb 6, 2016

@skirpichev skirpichev modified the milestone: 0.8.0 Sep 9, 2016

@skirpichev skirpichev changed the title Partial fix for sympy/sympy#4064 Partial fix for sympy/sympy#4064, test doit Sep 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment