New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build correct inhomogeneous solution in rsolve_hyper #298

Merged
merged 3 commits into from Jun 27, 2016

Conversation

1 participant
@skirpichev
Copy link
Collaborator

skirpichev commented Jun 24, 2016

Use rsolve_ratio instead.

Fixes #294

Closes sympy/sympy#11261
Closes sympy/sympy#7055

@skirpichev skirpichev force-pushed the skirpichev:fix-diofant294 branch from 2716881 to 8202c4d Jun 25, 2016

Build correct inhomogeneous solution in rsolve_hyper
Use rsolve_ratio instead.  (If it returns a generic
solution - we substitute back 0's for symbols in one.)

Fixes #294

Closes sympy/sympy#11261
Closes sympy/sympy#7055

@skirpichev skirpichev force-pushed the skirpichev:fix-diofant294 branch 2 times, most recently from 731afda to e1d2e52 Jun 26, 2016

skirpichev added some commits Jun 25, 2016

rsolve_poly/hyper fixes
1) cancel common factors early in rsolve_poly,
   e.g. for rsolve_poly([-n - 1, n + 1], n*(n + 1)**2, n)

2) in rsolve_hyper we skip initial zero/infinite terms of the
   product of ratio's, if one has zeros or poles as function of n.
   For example: rsolve_hyper([-n, 1], 0, n).
Return 0 solution for homogeneous eqs
This reverts 0fb85d3.  This 0 should be handled
on the rsolve level.

@skirpichev skirpichev merged commit fad8141 into diofant:master Jun 27, 2016

3 checks passed

codecov/patch 93% of diff hit (target 90%)
Details
codecov/project 90% (+<1%) compared to 0a8b93a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skirpichev skirpichev deleted the skirpichev:fix-diofant294 branch Jun 27, 2016

@skirpichev skirpichev modified the milestone: 0.8.0 Sep 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment