New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make complex numbers - finite in old assumptions #42

Merged
merged 8 commits into from Jan 7, 2016

Conversation

1 participant
@skirpichev
Copy link
Collaborator

skirpichev commented Apr 1, 2015

No description provided.

@skirpichev skirpichev referenced this pull request Apr 1, 2015

Closed

assumptions todo #34

9 of 9 tasks complete

@skirpichev skirpichev force-pushed the make-complex-finite branch from 5a5458b to ce6c145 May 3, 2015

@skirpichev skirpichev force-pushed the make-complex-finite branch from ce6c145 to 9933849 Jul 19, 2015

@skirpichev skirpichev force-pushed the make-complex-finite branch from 9933849 to 3bdce3b Aug 22, 2015

@skirpichev skirpichev force-pushed the make-complex-finite branch from 3bdce3b to 672d912 Oct 3, 2015

@skirpichev skirpichev force-pushed the make-complex-finite branch from 4d859eb to 5ac0742 Dec 4, 2015

@skirpichev skirpichev force-pushed the make-complex-finite branch 4 times, most recently from c960764 to 2c5240a Dec 19, 2015

@skirpichev skirpichev force-pushed the make-complex-finite branch 3 times, most recently from eba222d to ec63584 Dec 26, 2015

@skirpichev skirpichev force-pushed the make-complex-finite branch 5 times, most recently from a7dd3d2 to 64d6526 Jan 3, 2016

skirpichev added some commits Apr 1, 2015

Make complex numbers - finite in old assumptions [1/2]
Adapt some doctests and fix oo/-oo/zoo
assumptions in test_assumptions.py.
Make complex numbers - finite in old assumptions [2/2]
Change extended_real -> real in some tests.
Modify is_real and remove is_extended_real/is_finite helpers for sin/cos
sin(oo).is_finite or sin(oo).is_extended_real is not
True anymore.  sin(oo) or cos(oo) are not numbers and finite or
extended_real assumptions - not valid for them.  Instead, in future we
could implement bounded/unbounded assumptions for sets and/or
objects like sin(oo).

In this commit we also adapt core tests (don't use sin(x) for
is_finite tests).
Implement a diferent workaround for sin/cos in heuristics()
Also, here we revert back test_heuristics to the state before be030c2.

(This is a single case across the whole codebase, where is_bounded
assumption could be useful in the future.)

@skirpichev skirpichev force-pushed the make-complex-finite branch from 64d6526 to f377d5a Jan 6, 2016

skirpichev added a commit that referenced this pull request Jan 7, 2016

Merge pull request #42 from skirpichev/make-complex-finite
Make complex numbers - finite in old assumptions

@skirpichev skirpichev merged commit 3299539 into master Jan 7, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 91.918%
Details

@skirpichev skirpichev deleted the make-complex-finite branch Jan 7, 2016

@skirpichev skirpichev modified the milestone: 0.8.0 Sep 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment