New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable algebraic extensions by default #478

Merged
merged 6 commits into from Dec 15, 2018

Conversation

1 participant
@skirpichev
Copy link
Collaborator

skirpichev commented Mar 26, 2017

see sympy/sympy#5428, sympy/sympy#7724

  • fix for test_M39
  • rebase & cleanup
  • check tests
  • add regression tests
  • add tests for polys over gaussian rationals
  • remove unnecessary extension=True from docs
  • release notes
  • fix #723

@skirpichev skirpichev force-pushed the skirpichev:default-extension branch 2 times, most recently from a71f737 to 53f60a5 Apr 3, 2017

@skirpichev skirpichev force-pushed the skirpichev:default-extension branch 2 times, most recently from 34f0cd4 to 55cf5de Apr 8, 2017

@skirpichev skirpichev added this to the 0.9.0 milestone Apr 10, 2017

@skirpichev skirpichev force-pushed the skirpichev:default-extension branch 3 times, most recently from 692f368 to 64dd321 Apr 23, 2017

@skirpichev skirpichev force-pushed the skirpichev:default-extension branch from 64dd321 to ee32353 Jul 11, 2017

@skirpichev skirpichev modified the milestones: 0.9.0, 0.10 Oct 31, 2017

skirpichev added a commit to skirpichev/diofant that referenced this pull request Jan 9, 2018

Support extension option for some methods
Probably in future this could be reverted by making
extension=True - default for construct_domain(),
see e.g. diofant#478.

Related issues:
* sympy/sympy#5428
* sympy/sympy#7724
* sympy/sympy#12345

@skirpichev skirpichev force-pushed the skirpichev:default-extension branch from 537199e to 41bf47b Feb 21, 2018

@skirpichev skirpichev force-pushed the skirpichev:default-extension branch 4 times, most recently from 9682374 to 3e43499 Feb 26, 2018

@skirpichev skirpichev force-pushed the skirpichev:default-extension branch from 0e326a0 to c622adb Mar 9, 2018

@skirpichev skirpichev force-pushed the skirpichev:default-extension branch 2 times, most recently from c14e950 to 996e1bd Jun 15, 2018

@skirpichev skirpichev force-pushed the skirpichev:default-extension branch from 996e1bd to 6d7b073 Jun 23, 2018

@skirpichev skirpichev force-pushed the skirpichev:default-extension branch from 6d7b073 to 6e6febb Jul 7, 2018

@skirpichev skirpichev force-pushed the skirpichev:default-extension branch 2 times, most recently from b9db699 to 55b9e16 Jul 28, 2018

@skirpichev skirpichev force-pushed the skirpichev:default-extension branch from e1f06f2 to 5ceb537 Nov 9, 2018

@skirpichev skirpichev force-pushed the skirpichev:default-extension branch from 5ceb537 to 1984442 Nov 9, 2018

@skirpichev skirpichev force-pushed the skirpichev:default-extension branch 2 times, most recently from d13d8ce to 95596ed Nov 18, 2018

skirpichev referenced this pull request in skirpichev/diofant Nov 21, 2018

@skirpichev skirpichev force-pushed the skirpichev:default-extension branch 2 times, most recently from 940bb63 to 5ee2bc3 Dec 9, 2018

skirpichev added some commits Dec 11, 2018

polys: construct_domain() enable algebraic extensions by default
Before:
    In [1]: Poly(x**2 + sqrt(2), x)
    Out[1]: Poly(x**2 + sqrt(2), x, domain='EX')

    In [2]: Poly(x**2 + sqrt(2))
    Out[2]: Poly(x**2 + sqrt(2), x, sqrt(2), domain='ZZ')

After:
    In [1]: Poly(x**2 + sqrt(2), x)
    Out[1]: Poly(x**2 + sqrt(2), x, domain='QQ<sqrt(2)>')

    In [2]: Poly(x**2 + sqrt(2))
    Out[2]: Poly(x**2 + sqrt(2), x, sqrt(2), domain='ZZ')

Closes sympy/sympy#5428
Closes sympy/sympy#542814337
Workarounds for above commit
Working with algebraic number fields is still slow, so, in
several places we enforce extension=False and/or explicit
using of EX domain.

@skirpichev skirpichev force-pushed the skirpichev:default-extension branch from 5ee2bc3 to 782f37f Dec 11, 2018

@skirpichev skirpichev force-pushed the skirpichev:default-extension branch from ebc7a71 to 782f37f Dec 12, 2018

@skirpichev skirpichev changed the title [wip] Enable algebraic extensions by default Enable algebraic extensions by default Dec 13, 2018

@skirpichev skirpichev merged commit 0962465 into diofant:master Dec 15, 2018

3 checks passed

codecov/patch 100% of diff hit (target 97%)
Details
codecov/project Absolute coverage decreased by -<1% but relative coverage increased by +2% compared to ba2017e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skirpichev skirpichev deleted the skirpichev:default-extension branch Dec 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment