# diofant/diofant

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

# Enable algebraic extensions by default #478

Merged
merged 6 commits into from Dec 15, 2018

## Conversation

1 participant
Collaborator

### skirpichev commented Mar 26, 2017 • edited

 fix for test_M39 rebase & cleanup check tests add regression tests add tests for polys over gaussian rationals remove unnecessary extension=True from docs release notes fix #723

Open

Merged

### skirpichev added a commit to skirpichev/diofant that referenced this pull request Jan 9, 2018

``` Support extension option for some methods ```
```Probably in future this could be reverted by making
extension=True - default for construct_domain(),
see e.g. diofant#478.

Related issues:
* sympy/sympy#5428
* sympy/sympy#7724
* sympy/sympy#12345```
``` b6a556d ```

Open

### skirpichev referenced this pull request in skirpichev/diofant Nov 21, 2018

``` Add regression test ```
`Closes sympy/sympy#15311`
``` 92a7f9e ```

### skirpichev added some commits Dec 11, 2018

``` polys: construct_domain() enable algebraic extensions by default ```
```Before:
In [1]: Poly(x**2 + sqrt(2), x)
Out[1]: Poly(x**2 + sqrt(2), x, domain='EX')

In [2]: Poly(x**2 + sqrt(2))
Out[2]: Poly(x**2 + sqrt(2), x, sqrt(2), domain='ZZ')

After:
In [1]: Poly(x**2 + sqrt(2), x)
Out[1]: Poly(x**2 + sqrt(2), x, domain='QQ<sqrt(2)>')

In [2]: Poly(x**2 + sqrt(2))
Out[2]: Poly(x**2 + sqrt(2), x, sqrt(2), domain='ZZ')

Closes sympy/sympy#5428
Closes sympy/sympy#542814337```
``` d6a062e ```
``` Workarounds for above commit ```
```Working with algebraic number fields is still slow, so, in
several places we enforce extension=False and/or explicit
using of EX domain.```
``` b0a752a ```
``` Adapt tests after turning on extention=True per default ```
``` 782f37f ```

### skirpichev added some commits Dec 12, 2018

``` Drop Rational._mpmath_() helper (not needed for new mpmath) ```
``` cc0fc4e ```
``` domains: drop redundant coersion helper for EX ```
``` 83a74c7 ```
``` Add coverage test for roots_cubic() ```
``` c684641 ```

### skirpichev merged commit `0962465` into diofant:master Dec 15, 2018 3 checks passed

#### 3 checks passed

codecov/patch 100% of diff hit (target 97%)
Details
codecov/project Absolute coverage decreased by -<1% but relative coverage increased by +2% compared to ba2017e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

### skirpichev deleted the skirpichev:default-extension branch Dec 15, 2018

to join this conversation on GitHub. Already have an account? Sign in to comment