New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Basic.subs - single arg method (support a mapping or an iterable of pairs) #532

Merged
merged 10 commits into from Nov 12, 2018

Conversation

1 participant
@skirpichev
Collaborator

skirpichev commented Aug 28, 2017

  • without Wild's: x.match(x) should be {x: x}?
  • has vs find
  • atoms vs find
  • match vs matches
  • .subs(old, new) vs .subs(dict) -> .subs(iterable of pairs or mapping)?
  • .subs vs Subs arguments

@skirpichev skirpichev added this to the 0.9.0 milestone Aug 28, 2017

@skirpichev skirpichev force-pushed the skirpichev:matching-interface branch 2 times, most recently from 1927461 to 0fcac32 Aug 29, 2017

@skirpichev skirpichev force-pushed the skirpichev:matching-interface branch from b7b4035 to 009a70a Sep 7, 2017

@skirpichev skirpichev force-pushed the skirpichev:matching-interface branch 2 times, most recently from 8b0756e to f040e0b Sep 14, 2017

@skirpichev skirpichev force-pushed the skirpichev:matching-interface branch from f040e0b to 62e4b1d Sep 26, 2017

@skirpichev skirpichev force-pushed the skirpichev:matching-interface branch 6 times, most recently from 57d1604 to b3fe1a5 Oct 10, 2017

@skirpichev skirpichev modified the milestones: 0.9.0, 0.10 Oct 31, 2017

@skirpichev skirpichev force-pushed the skirpichev:matching-interface branch from b3fe1a5 to ecafea2 Nov 1, 2017

@skirpichev skirpichev force-pushed the skirpichev:matching-interface branch from d7e5318 to 2312887 Dec 7, 2017

@skirpichev skirpichev force-pushed the skirpichev:matching-interface branch 2 times, most recently from 8f22e62 to 046762d Jan 18, 2018

@skirpichev skirpichev force-pushed the skirpichev:matching-interface branch from 046762d to 9d8567e Feb 16, 2018

@skirpichev skirpichev force-pushed the skirpichev:matching-interface branch from 9d8567e to 6a3193c Mar 16, 2018

@skirpichev skirpichev force-pushed the skirpichev:matching-interface branch from 6a3193c to f129d97 May 15, 2018

@skirpichev skirpichev force-pushed the skirpichev:matching-interface branch from f129d97 to 5a7ba18 May 30, 2018

@skirpichev skirpichev force-pushed the skirpichev:matching-interface branch from 5a7ba18 to da31eb7 Jul 6, 2018

@skirpichev skirpichev force-pushed the skirpichev:matching-interface branch 2 times, most recently from b2cdd5a to db0a96e Jul 29, 2018

@skirpichev skirpichev force-pushed the skirpichev:matching-interface branch from db0a96e to 94bf3d0 Sep 19, 2018

@skirpichev skirpichev force-pushed the skirpichev:matching-interface branch from 94bf3d0 to 98a8bf9 Sep 19, 2018

@skirpichev skirpichev force-pushed the skirpichev:matching-interface branch from 98a8bf9 to 37fe9f2 Oct 12, 2018

@skirpichev skirpichev force-pushed the skirpichev:matching-interface branch 2 times, most recently from eb3513c to 26793c1 Nov 5, 2018

@skirpichev skirpichev changed the title [wip] Improve/document interfaces for search/replacement Make Basic.subs - single arg method (support a mapping or an iterable of pairs) Nov 8, 2018

@skirpichev skirpichev force-pushed the skirpichev:matching-interface branch from 26793c1 to faedfa3 Nov 8, 2018

@skirpichev skirpichev force-pushed the skirpichev:matching-interface branch from faedfa3 to f1ce93d Nov 11, 2018

@skirpichev skirpichev force-pushed the skirpichev:matching-interface branch from f1ce93d to b435a71 Nov 11, 2018

skirpichev added some commits Nov 11, 2018

Remove some redundant type casts (to Rational)
Also change Rational(123) -> Integer(123), where appropriate.
Relax pytest-xdist requirement
Currently, it's used for travis-ci only.
Create dedicated extras to track testing requirements
Closes #699

Unfortunately, it's impossible reuse this in the develop
extras (as .[tests]), see pypa/setuptools#1260.
Removed test_failing_integrals.py
Few tests were moved to test_integrals.py

Some remarks:
1) Timeout stuff removed - we can use pytest-timeout plugin.
2) test_sympyissue_3880, test_sympyissue_4525,
   test_sympyissue_4941 - are hangs.
3) test_sympyissue_4326 - solved issue, there is a test.
4) test_sympyissue_1638b - solved, there is a test with a correct value.
5) test_sympyissue_4895* - solved, a duplicate of sympy/sympy#3940.
   There is a test.
6) test_sympyissue_4992 - solved, there is a test.
7) test_sympyissue_4064 - actually issue sympy/sympy#7163, which is
   fixed, there is a test.

Closes sympy/sympy#4511

@skirpichev skirpichev force-pushed the skirpichev:matching-interface branch from b435a71 to 705d11a Nov 12, 2018

@skirpichev skirpichev merged commit 173ed6d into diofant:master Nov 12, 2018

3 checks passed

codecov/patch 97% of diff hit (target 97%)
Details
codecov/project Absolute coverage decreased by -<1% but relative coverage increased by +<1% compared to ad5ca81
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skirpichev skirpichev deleted the skirpichev:matching-interface branch Nov 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment