New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generating vectors in primitive_element() and misc fixes #608

Merged
merged 11 commits into from Feb 13, 2018

Conversation

1 participant
@skirpichev
Copy link
Collaborator

skirpichev commented Feb 12, 2018

No description provided.

@skirpichev skirpichev added this to the 0.9 milestone Feb 12, 2018

@skirpichev skirpichev force-pushed the skirpichev:misc branch from c490f35 to 778d918 Feb 13, 2018

skirpichev added some commits Feb 12, 2018

polys: fix generating vectors in primitive_element()
Naive implementation, used before, included too many
linearly dependent (over QQ) vectors.  Now we use
"Type 1" variant from the quoted paper.  Reference added.

Closes sympy/sympy#14117

@skirpichev skirpichev force-pushed the skirpichev:misc branch from 778d918 to fdd6709 Feb 13, 2018

@skirpichev skirpichev merged commit a544764 into diofant:master Feb 13, 2018

3 checks passed

codecov/patch 100% of diff hit (target 97%)
Details
codecov/project Absolute coverage decreased by -<1% but relative coverage increased by +3% compared to df833ab
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skirpichev skirpichev deleted the skirpichev:misc branch Feb 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment