New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New class for algebraic number field elements #619

Merged
merged 2 commits into from Mar 16, 2018

Conversation

1 participant
@skirpichev
Copy link
Collaborator

skirpichev commented Mar 3, 2018

  • replace ANP in polys/domains code
  • use reference to AlgebraicField
  • remove ANP
  • rename AlgebraicElement to AlgebraicNumber?
  • rich comparisons & sorting (see sympy/sympy#14210)
  • fix docs
  • fix test naming
  • cleanup
  • rebase
  • pickling
  • release notes

@skirpichev skirpichev added this to the 0.10 milestone Mar 3, 2018

@skirpichev skirpichev force-pushed the skirpichev:new-ANP branch 2 times, most recently from 753226b to e8537fe Mar 5, 2018

@skirpichev skirpichev referenced this pull request Mar 6, 2018

Closed

Comparison of ANP #618

@skirpichev skirpichev force-pushed the skirpichev:new-ANP branch 9 times, most recently from 4ef805b to f76375d Mar 7, 2018

@skirpichev skirpichev removed the testing label Mar 14, 2018

skirpichev added some commits Mar 12, 2018

polys: removed to_number_field()
Use Domain.convert() instead.

@skirpichev skirpichev force-pushed the skirpichev:new-ANP branch from f76375d to 29d0dd0 Mar 15, 2018

@skirpichev skirpichev changed the title [wip] New class for algebraic number field elements New class for algebraic number field elements Mar 15, 2018

@skirpichev skirpichev merged commit 46cb86e into diofant:master Mar 16, 2018

3 checks passed

codecov/patch 100% of diff hit (target 97%)
Details
codecov/project Absolute coverage decreased by -<1% but relative coverage increased by +3% compared to 8db38e0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skirpichev skirpichev deleted the skirpichev:new-ANP branch Mar 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment